Bug 192109

Summary: Web Inspector: Styles: enable selection of multiple properties by default
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
hi: review+
Patch none

Nikita Vasilyev
Reported 2018-11-28 15:16:12 PST
Keep the feature enabled and remove the experimental setting.
Attachments
Patch (11.50 KB, patch)
2018-11-28 15:41 PST, Nikita Vasilyev 		hi: review+
DetailsFormatted DiffDiff
Patch (11.53 KB, patch)
2018-11-28 16:22 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-28 15:16:54 PST
<rdar://problem/46323565>
Nikita Vasilyev
Comment 2 2018-11-28 15:41:38 PST
Created attachment 355937 [details] Patch
Devin Rousso
Comment 3 2018-11-28 16:11:54 PST
Comment on attachment 355937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355937&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:53 > +.spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing) { Is this rule actually needed? Can we remove it? > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:64 > +.spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing) { This rule is a duplicate of (53), so please remove it.
Nikita Vasilyev
Comment 4 2018-11-28 16:16:55 PST
Comment on attachment 355937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355937&action=review >> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:53 >> +.spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing) { > > Is this rule actually needed? Can we remove it? It's still needed. Start editing name or value, focus another window, and then focus Web Inspector again. >> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:64 >> +.spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing) { > > This rule is a duplicate of (53), so please remove it. Huh, must have been from a bad merge before.
Nikita Vasilyev
Comment 5 2018-11-28 16:22:31 PST
Created attachment 355941 [details] Patch
WebKit Commit Bot
Comment 6 2018-11-28 17:10:33 PST
The commit-queue encountered the following flaky tests while processing attachment 355941 [details]: webgl/1.0.2/conformance/more/functions/copyTexImage2D.html bug 192125 (author: roger_fong@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2018-11-28 17:11:21 PST
Comment on attachment 355941 [details] Patch Clearing flags on attachment: 355941 Committed r238649: <https://trac.webkit.org/changeset/238649>
WebKit Commit Bot
Comment 8 2018-11-28 17:11:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.