Bug 192727

Summary: [WebAuthN] Remove hash from Client Data
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.gaynor, bfulgham, cdumez, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch none

Jiewen Tan
Reported 2018-12-14 16:49:43 PST
Remove hash from Client Data. The hash algorithm for hashing the client data is enforced to SHA_256 in the latest spec: https://www.w3.org/TR/webauthn/#sec-client-data. Therefore, we should remove it.
Attachments
Patch (7.47 KB, patch)
2018-12-14 17:07 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-14 16:52:49 PST
<rdar://problem/46746673>
Jiewen Tan
Comment 2 2018-12-14 17:07:47 PST
Created attachment 357359 [details] Patch
Brent Fulgham
Comment 3 2018-12-20 14:07:03 PST
Comment on attachment 357359 [details] Patch Reviewed with Jiewen in person. r=me.
Jiewen Tan
Comment 4 2018-12-20 14:21:40 PST
Comment on attachment 357359 [details] Patch Thanks for Brent to r+ this patch.
WebKit Commit Bot
Comment 5 2018-12-20 15:55:57 PST
Comment on attachment 357359 [details] Patch Clearing flags on attachment: 357359 Committed r239471: <https://trac.webkit.org/changeset/239471>
WebKit Commit Bot
Comment 6 2018-12-20 15:55:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.