Bug 192792

Summary: [WebAuthN] Add a runtime flag for local authenticator
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.gaynor, bfulgham, cdumez, commit-queue, ews-watchlist, jiewen_tan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews101 for mac-sierra
none
Archive of layout-test-results from ews117 for mac-sierra
none
Patch none

Jiewen Tan
Reported 2018-12-17 18:53:02 PST
Add a runtime flag for local authenticator.
Attachments
Patch (19.42 KB, patch)
2018-12-17 19:03 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-sierra (2.42 MB, application/zip)
2018-12-17 20:10 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews117 for mac-sierra (1.96 MB, application/zip)
2018-12-17 20:58 PST, EWS Watchlist 		no flags
Details
Patch (22.07 KB, patch)
2018-12-18 14:24 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-12-17 18:53:45 PST
<rdar://problem/46798738>
Jiewen Tan
Comment 2 2018-12-17 19:03:19 PST
Created attachment 357516 [details] Patch
EWS Watchlist
Comment 3 2018-12-17 20:10:18 PST
Comment on attachment 357516 [details] Patch Attachment 357516 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10450813 New failing tests: fast/dom/navigator-detached-no-crash.html
EWS Watchlist
Comment 4 2018-12-17 20:10:20 PST
Created attachment 357523 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 5 2018-12-17 20:58:48 PST
Comment on attachment 357516 [details] Patch Attachment 357516 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10451095 New failing tests: fast/dom/navigator-detached-no-crash.html
EWS Watchlist
Comment 6 2018-12-17 20:58:49 PST
Created attachment 357528 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Jiewen Tan
Comment 7 2018-12-18 14:24:59 PST
Created attachment 357612 [details] Patch
Brent Fulgham
Comment 8 2018-12-20 14:08:33 PST
Comment on attachment 357612 [details] Patch r=me
Jiewen Tan
Comment 9 2018-12-20 14:20:16 PST
Comment on attachment 357612 [details] Patch Thanks for Brent to r+ this patch.
WebKit Commit Bot
Comment 10 2018-12-20 15:54:57 PST
Comment on attachment 357612 [details] Patch Clearing flags on attachment: 357612 Committed r239470: <https://trac.webkit.org/changeset/239470>
WebKit Commit Bot
Comment 11 2018-12-20 15:54:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.