Bug 193227

Summary: Web Inspector: Audit: provide a way to get related Accessibility properties for a given node
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, hi, inspector-bugzilla-changes, jcraig, jdiggs, joepeck, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190754, 193149    
Bug Blocks:    
Attachments:
Description Flags
Patch
hi: commit-queue-
Patch
none
Patch
none
Patch none

Devin Rousso
Reported 2019-01-07 21:30:20 PST
This corresponds to the following `DOM.AccessibilityProperties` properties: - busy - checked - current - disabled - expanded - focused - headingLevel - hidden - hierarchyLevel - ignored - ignoredByDefault - invalid - isPopUpButton - label - liveRegionAtomic - liveRegionRelevant - liveRegionStatus - pressed - readonly - required - role - selected
Attachments
Patch (10.04 KB, patch)
2019-01-07 21:32 PST, Devin Rousso 		hi: commit-queue-
DetailsFormatted DiffDiff
Patch (12.56 KB, patch)
2019-01-10 17:03 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (15.01 KB, patch)
2019-01-22 14:33 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (15.20 KB, patch)
2019-01-22 15:08 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-01-07 21:30:41 PST
<rdar://problem/46787862>
Devin Rousso
Comment 2 2019-01-07 21:32:20 PST
Created attachment 358569 [details] Patch Will write tests later, once I have had a chance to look more into the other inspector accessibility tests.
Devin Rousso
Comment 3 2019-01-10 17:03:12 PST
Created attachment 358853 [details] Patch
Joseph Pecoraro
Comment 4 2019-01-14 14:16:55 PST
Comment on attachment 358853 [details] Patch r-, this one needs some kind of test (even if it is not exhaustive but at least tests the code path. Otherwise this seems good.
Devin Rousso
Comment 5 2019-01-22 14:33:51 PST
Created attachment 359775 [details] Patch
Joseph Pecoraro
Comment 6 2019-01-22 15:00:48 PST
Comment on attachment 359775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359775&action=review r=me > LayoutTests/inspector/audit/run-accessibility.html:21 > + return JSON.stringify(mapped); You could prettyify this `JSON.stringify(mapped, null, 4)` which would make failure diffs easy to understand if a single property changed.
Devin Rousso
Comment 7 2019-01-22 15:08:22 PST
Created attachment 359783 [details] Patch
WebKit Commit Bot
Comment 8 2019-01-22 16:33:04 PST
Comment on attachment 359783 [details] Patch Clearing flags on attachment: 359783 Committed r240309: <https://trac.webkit.org/changeset/240309>
WebKit Commit Bot
Comment 9 2019-01-22 16:33:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.