Bug 196720

Summary: [CMake] Apple builds should use ICU_INCLUDE_DIRS
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
annulen: review+
Patch none

Don Olmstead
Reported 2019-04-08 18:25:11 PDT
The Apple platform is using ${DERIVED_SOURCES_WTF_DIR} for hosting the ICU headers. Instead it should stage the headers into ${ICU_INCLUDE_DIRS} so no special handling is needed.
Attachments
Patch (6.95 KB, patch)
2019-04-08 18:27 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (7.16 KB, patch)
2019-04-08 18:32 PDT, Don Olmstead 		annulen: review+
DetailsFormatted DiffDiff
Patch (7.33 KB, patch)
2019-04-09 09:08 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2019-04-08 18:27:48 PDT Comment hidden (obsolete)
Don Olmstead
Comment 2 2019-04-08 18:32:14 PDT
Created attachment 367007 [details] Patch
Konstantin Tokarev
Comment 3 2019-04-09 07:35:35 PDT
Comment on attachment 367007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367007&action=review > ChangeLog:8 > + Set ICU_INCLUDE_DIRS for Apple platforms. Please add description from your Bugzilla comment, it's more informative
Don Olmstead
Comment 4 2019-04-09 09:08:24 PDT
Created attachment 367041 [details] Patch Adding more descriptive changelog.
WebKit Commit Bot
Comment 5 2019-04-09 09:54:12 PDT
The commit-queue encountered the following flaky tests while processing attachment 367041 [details]: imported/w3c/web-platform-tests/xhr/event-upload-progress.htm bug 196736 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2019-04-09 09:54:28 PDT
The commit-queue encountered the following flaky tests while processing attachment 367041 [details]: media/W3C/video/events/event_progress.html bug 196637 (author: pilgrim@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2019-04-09 09:57:28 PDT
Comment on attachment 367041 [details] Patch Clearing flags on attachment: 367041 Committed r244081: <https://trac.webkit.org/changeset/244081>
WebKit Commit Bot
Comment 8 2019-04-09 09:57:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.