Bug 19728

Summary: [Qt] Support text-shadow blur
Product: WebKit Reporter: Jonathon Jongsma (jonner) <jonathon>
Component: TextAssignee: Ariya Hidayat <ariya.hidayat>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ademar, ariya.hidayat, benjamin, bero, hausmann, j, vestbo
Priority: P3 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 34479    
Attachments:
Description Flags
Screenshot of the result of applying the patch
none
Patch kenneth: review+

Jonathon Jongsma (jonner)
Reported 2008-06-23 09:14:58 PDT
There is an initial patch to support text shadows in the Qt port (Bug #18459), but that doesn't yet support blur. There is a commented-out function GraphicsContext::drawTextShadow() in the source that seems to have a blur implementation. We should try to port this to the new text-shadow implementation.
Attachments
Screenshot of the result of applying the patch (278.71 KB, image/png)
2010-08-23 16:06 PDT, Ariya Hidayat 		no flags
Details
Patch (6.74 KB, patch)
2010-08-23 16:07 PDT, Ariya Hidayat 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathon Jongsma (jonner)
Comment 1 2008-06-24 10:58:18 PDT
hm, I tried to port the old implementation and performance seemed incredibly bad. I may have done something wrong, but my first impression is that it will be difficult to add blur support with decent performance. I may come back to this later, but I'm moving on to other things for the moment. If anybody else is interested in adding blur, feel free to grab this bug.
Simon Hausmann
Comment 2 2008-06-25 01:09:48 PDT
I can imagine that the performance is related to the FIXME's in the old code, which allocates a QImage with the size of the entire viewport.
Ariya Hidayat
Comment 3 2010-08-12 12:17:35 PDT
Add and assign to myself.
Ariya Hidayat
Comment 4 2010-08-12 12:20:01 PDT
See also https://bugs.webkit.org/show_bug.cgi?id=34479
Ariya Hidayat
Comment 5 2010-08-23 16:06:48 PDT
Created attachment 65169 [details] Screenshot of the result of applying the patch I have a patch ready, the attached screenshot shows the result of the blur shadow.
Ariya Hidayat
Comment 6 2010-08-23 16:07:41 PDT
Created attachment 65170 [details] Patch
Kenneth Rohde Christiansen
Comment 7 2010-08-24 00:35:27 PDT
Comment on attachment 65170 [details] Patch Isn't there some way to factor some of this into online methods?
Ariya Hidayat
Comment 8 2010-08-24 00:41:39 PDT
> Isn't there some way to factor some of this into online methods? It is not trivial since one works with QPainter::drawText while the other uses QTextLayout/QTextLine. It is unfortunate that the boilerplate for the prolog and epilog are similar, but I can't see a clean way to refactor them, without falling back to C-ism macro magic.
Ariya Hidayat
Comment 9 2010-08-24 02:02:30 PDT
Committed r65876: <http://trac.webkit.org/changeset/65876>
Ademar Reis
Comment 10 2010-11-16 09:15:53 PST
There must be a very good reason to include any more bugs as blockers for the qtwebkit-2.1 release at this point. Since I don't see one, I'm removing it from the blocking list. :-) Feel free to add it as a *candidate* for inclusion (bug #44677) and please state the motivation/reason/requirement for it.
Note You need to log in before you can comment on or make changes to this bug.