Bug 197838

Summary:

[FreeType] Some character sequences with a variation selector are not rendered

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, ews-watchlist, mcatanzaro, mmaxfield, webkit-bug-importer

Priority:

Keywords:

Gtk, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mcatanzaro: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews212 for win-future	none

Carlos Garcia Campos

Reported 2019-05-13 07:58:40 PDT

We get the invalid glyph instead. See http://mts.io/2015/04/21/unicode-symbol-render-text-emoji/ In the table at the end the Emoji and Text columns are not correctly rendered. It happens also when copying an emoji from GtkEmojiChooser and pasting in WebKit text field, because GTK appends U+FE0F to all emojis to force the emoji style.

Attachments
Patch (9.82 KB, patch) 2019-05-13 08:12 PDT, Carlos Garcia Campos	mcatanzaro: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews212 for win-future (13.60 MB, application/zip) 2019-05-14 00:34 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2019-05-13 08:12:59 PDT

Created attachment 369732 [details] Patch I've tried to make a test for this, but it's not easy, at least not for GTK, because I get different width/height offset when rendering directly with emoji font than when falling back to it. I don't know why. The thing is that a ref test always fails with very few pixels difference.

EWS Watchlist

Comment 2 2019-05-14 00:34:08 PDT Comment hidden (spam)

Comment on attachment 369732 [details] Patch Attachment 369732 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12185244 New failing tests: http/tests/security/local-video-src-from-remote.html

EWS Watchlist

Comment 3 2019-05-14 00:34:10 PDT Comment hidden (spam)

Created attachment 369824 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Michael Catanzaro

Comment 4 2019-05-14 05:54:13 PDT

Comment on attachment 369732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369732&action=review > Source/WebCore/ChangeLog:11 > + style. We need to take into account the variaiton selector when checking if a font can render a combining variation

Carlos Garcia Campos

Comment 5 2019-05-16 02:31:23 PDT

Committed r245393: <https://trac.webkit.org/changeset/245393>

Radar WebKit Bug Importer

Comment 6 2019-05-16 02:32:21 PDT

<rdar://problem/50846399>

Note You need to log in before you can comment on or make changes to this bug.