Bug 199604

Summary: [WHLSL] Import 23 new JS reference spec tests
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 199595    
Attachments:
Description Flags
patch
mmaxfield: review+, saam: commit-queue-
patch for landing
saam: commit-queue-
patch for landing
none
patch for landing none

Saam Barati
Reported 2019-07-08 18:39:39 PDT
...
Attachments
patch (26.26 KB, patch)
2019-07-08 18:48 PDT, Saam Barati 		mmaxfield: review+
saam: commit-queue-
DetailsFormatted DiffDiff
patch for landing (26.20 KB, patch)
2019-07-08 19:14 PDT, Saam Barati 		saam: commit-queue-
DetailsFormatted DiffDiff
patch for landing (26.30 KB, patch)
2019-07-08 19:31 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (27.53 KB, patch)
2019-07-08 19:38 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-07-08 18:48:12 PDT
Created attachment 373689 [details] patch
Saam Barati
Comment 2 2019-07-08 19:01:02 PDT
I broke some stuff
Saam Barati
Comment 3 2019-07-08 19:12:04 PDT
Comment on attachment 373689 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=373689&action=review > Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:51 > - Visitor::visit(functionDefinition); > + checkErrorAndVisit(functionDefinition); This should have stayed Visitor::visit > Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:61 > - Visitor::visit(callExpression.function()); > + checkErrorAndVisit(callExpression); ditto
Saam Barati
Comment 4 2019-07-08 19:14:32 PDT
Created attachment 373692 [details] patch for landing
Saam Barati
Comment 5 2019-07-08 19:31:28 PDT
Created attachment 373694 [details] patch for landing
Saam Barati
Comment 6 2019-07-08 19:38:00 PDT
Created attachment 373695 [details] patch for landing fix duplicate JS function errors.
WebKit Commit Bot
Comment 7 2019-07-08 22:32:33 PDT
Comment on attachment 373695 [details] patch for landing Clearing flags on attachment: 373695 Committed r247254: <https://trac.webkit.org/changeset/247254>
WebKit Commit Bot
Comment 8 2019-07-08 22:32:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-07-08 22:34:29 PDT
<rdar://problem/52816061>
Note You need to log in before you can comment on or make changes to this bug.