Bug 200815

Summary: [GTK][WPE] Enable service workers by default
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, cgarcia, clopez, commit-queue, dino, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, thorton, wenson_hsieh, youennf, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 203036    
Bug Blocks: 174541    
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2019-08-16 08:18:43 PDT
Currently service workers is enabled only when building with -DENABLE_EXPERIMENTAL_FEATURES=ON This feature has been in development since 2 years ago and Safari TP is already shipping it. Anyone knows about any blocker before enabling this by default? I will check the test pass-rates on WPT related tests.
Attachments
Patch (3.89 KB, patch)
2019-10-21 14:25 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2019-08-21 15:20:00 PDT
Running the JS and Ref tests for /service-workers on https://w3c-test.org/tools/runner/index.html gives the following result for the GTK MiniBrowser: Passed: 1192 Failed: 198 Timeouts: 63 Errors: 2 Not run: 70 So, around 82% of pass-rate.
Carlos Alberto Lopez Perez
Comment 2 2019-10-21 14:21:25 PDT
Here is another manual test for SW: https://serviceworke.rs/message-relay_demo.html it works fine
Carlos Alberto Lopez Perez
Comment 3 2019-10-21 14:25:01 PDT
Created attachment 381450 [details] Patch
WebKit Commit Bot
Comment 4 2019-10-22 01:51:46 PDT
Comment on attachment 381450 [details] Patch Clearing flags on attachment: 381450 Committed r251424: <https://trac.webkit.org/changeset/251424>
WebKit Commit Bot
Comment 5 2019-10-22 01:51:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.