Bug 201061

Summary: Undo disabling of IsoHeaps when Gigacage is off.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: New BugsAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201154
Bug Depends on: 187160    
Bug Blocks:    
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2019-08-22 17:45:43 PDT
This rolls outs https://trac.webkit.org/r233773 which was landed for https://bugs.webkit.org/show_bug.cgi?id=187160. <rdar://problem/54622500>
Attachments
proposed patch. (10.30 KB, patch)
2019-08-22 18:06 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-08-22 18:06:52 PDT
Created attachment 377086 [details] proposed patch.
Saam Barati
Comment 2 2019-08-22 21:57:26 PDT
Comment on attachment 377086 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=377086&action=review > Source/bmalloc/bmalloc/PerThread.h:2 > + * Copyright (C) 2014-2017 Apple Inc. All rights reserved. Is this intentional? Did you mean 2019? > Source/bmalloc/bmalloc/ProcessCheck.mm:-47 > - || [processName isEqualToString:@"DumpRenderTree"] Why?
Mark Lam
Comment 3 2019-08-22 22:19:42 PDT
Comment on attachment 377086 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=377086&action=review >> Source/bmalloc/bmalloc/PerThread.h:2 >> + * Copyright (C) 2014-2017 Apple Inc. All rights reserved. > > Is this intentional? Did you mean 2019? This came from the rollout. I can change this to 2019. >> Source/bmalloc/bmalloc/ProcessCheck.mm:-47 >> - || [processName isEqualToString:@"DumpRenderTree"] > > Why? This came straight from rolling out Michael's patch. My understanding is that this was added to workaround a DRT issue that came with this patch. Would like Michael to comment on whether this should be left in.
Michael Saboff
Comment 4 2019-08-23 09:56:36 PDT
Comment on attachment 377086 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=377086&action=review >>> Source/bmalloc/bmalloc/ProcessCheck.mm:-47 >>> - || [processName isEqualToString:@"DumpRenderTree"] >> >> Why? > > This came straight from rolling out Michael's patch. My understanding is that this was added to workaround a DRT issue that came with this patch. Would like Michael to comment on whether this should be left in. I think we should keep this in.
Mark Lam
Comment 5 2019-08-23 13:56:51 PDT
Thanks for the reviews. Landed in r249065: <http://trac.webkit.org/r249065>.
Note You need to log in before you can comment on or make changes to this bug.