Bug 201584

Summary: [Service Workers] Drop support for registration resurrection
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, jaffathecake, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://w3c.github.io/ServiceWorker/#unregister-algorithm
Bug Depends on:    
Bug Blocks: 201169    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2019-09-07 17:51:53 PDT
Drop support for registration resurrection (Unregistering then quickly re-registering would resurrect the original registration instead of creating a new one). This behavior is no longer in the specification (No more "isUninstalling" flag on the registration, and the registration is removed from the "scope to registration map" right away upon unregistering). This resurrection behavior was causing a lot of flakiness in the tests so it is likely we will be able to unskip some tests. This is also what was causing the flakiness that caused Bug 201169 to be rolled out.
Attachments
Patch (36.61 KB, patch)
2019-09-07 17:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (36.22 KB, patch)
2019-09-07 18:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (37.93 KB, patch)
2019-09-07 18:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2019-09-07 17:55:35 PDT
Created attachment 378308 [details] Patch
Chris Dumez
Comment 2 2019-09-07 18:10:39 PDT
Created attachment 378309 [details] Patch
Chris Dumez
Comment 3 2019-09-07 18:57:52 PDT
Created attachment 378311 [details] Patch
WebKit Commit Bot
Comment 4 2019-09-07 22:22:41 PDT
The commit-queue encountered the following flaky tests while processing attachment 378311 [details]: media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html bug 193587 (author: graouts@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2019-09-07 22:22:49 PDT
The commit-queue encountered the following flaky tests while processing attachment 378311 [details]: imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html bug 201588 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2019-09-07 22:42:57 PDT
Comment on attachment 378311 [details] Patch Clearing flags on attachment: 378311 Committed r249627: <https://trac.webkit.org/changeset/249627>
WebKit Commit Bot
Comment 7 2019-09-07 22:42:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-09-07 22:43:15 PDT
<rdar://problem/55155689>
Chris Dumez
Comment 9 2019-10-06 19:09:10 PDT
*** Bug 198602 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.