Bug 201785

Summary: Remove commit.h copying build steps
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, dino, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, rakuco, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 201156    
Bug Blocks: 198948    
Attachments:
Description Flags
Remove commit.h copying build steps none

James Darpinian
Reported 2019-09-13 17:26:02 PDT
Remove commit.h copying build steps
Attachments
Remove commit.h copying build steps (6.93 KB, patch)
2019-09-13 17:27 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2019-09-13 17:27:35 PDT
Created attachment 378767 [details] Remove commit.h copying build steps
EWS Watchlist
Comment 2 2019-09-13 17:28:08 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
James Darpinian
Comment 3 2019-09-13 17:36:46 PDT
Following up after my ANGLE update change. On an unrelated note, I don't have permission to update the wiki page. After my recent changes to ANGLE most of the steps are obsolete (3, 4, 5, 6) or can be performed automatically by the update-angle.sh script (1, 2). Can you update it? http://trac.webkit.org/wiki/UpdatingANGLE
WebKit Commit Bot
Comment 4 2019-09-16 01:46:52 PDT
Comment on attachment 378767 [details] Remove commit.h copying build steps Clearing flags on attachment: 378767 Committed r249892: <https://trac.webkit.org/changeset/249892>
WebKit Commit Bot
Comment 5 2019-09-16 01:46:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-16 01:47:29 PDT
<rdar://problem/55391834>
Radar WebKit Bug Importer
Comment 7 2019-09-16 01:47:30 PDT
<rdar://problem/55391835>
Note You need to log in before you can comment on or make changes to this bug.