Bug 202564

Summary: [WebAuthn] Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.gaynor, bfulgham, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch none

Jiewen Tan
Reported 2019-10-03 22:46:21 PDT
Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:].
Attachments
Patch (6.47 KB, patch)
2019-10-11 01:15 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-10-03 22:46:55 PDT
<rdar://problem/55974027>
Jiewen Tan
Comment 2 2019-10-11 01:15:24 PDT
Created attachment 380732 [details] Patch
Jiewen Tan
Comment 3 2019-10-11 12:09:48 PDT
Not sure how the API test failure is related to this patch.
Jiewen Tan
Comment 4 2019-10-11 13:11:09 PDT
(In reply to Jiewen Tan from comment #3) > Not sure how the API test failure is related to this patch. The test is super flaky in my local test.
Brent Fulgham
Comment 5 2019-10-15 09:14:50 PDT
Comment on attachment 380732 [details] Patch r=me
Jiewen Tan
Comment 6 2019-10-15 10:37:55 PDT
(In reply to Brent Fulgham from comment #5) > Comment on attachment 380732 [details] > Patch > > r=me Thanks Brent for r+ this patch. Will coordinate with the internal patch to land this properly.
WebKit Commit Bot
Comment 7 2019-10-15 13:45:30 PDT
Comment on attachment 380732 [details] Patch Clearing flags on attachment: 380732 Committed r251154: <https://trac.webkit.org/changeset/251154>
WebKit Commit Bot
Comment 8 2019-10-15 13:45:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.