Bug 202824

Summary: Invoke callback registered by requestIdleCallback
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, esprehn+autocc, ews-watchlist, ggaren, hotaru, kangil.han, koivisto, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202876
Bug Depends on:    
Bug Blocks: 164193    
Attachments:
Description Flags
Adds more scaffolding
none
Add the forgotten file
koivisto: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews215 for win-future none

Ryosuke Niwa
Reported 2019-10-10 14:16:14 PDT
Invoke these callbacks at all.
Attachments
Adds more scaffolding (21.83 KB, patch)
2019-10-10 14:38 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Add the forgotten file (27.11 KB, patch)
2019-10-10 19:25 PDT, Ryosuke Niwa 		koivisto: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews215 for win-future (14.25 MB, application/zip)
2019-10-11 03:35 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2019-10-10 14:38:23 PDT
Created attachment 380687 [details] Adds more scaffolding
Ryosuke Niwa
Comment 2 2019-10-10 19:25:05 PDT
Created attachment 380715 [details] Add the forgotten file
Ryosuke Niwa
Comment 3 2019-10-10 19:27:40 PDT
Comment on attachment 380715 [details] Add the forgotten file View in context: https://bugs.webkit.org/attachment.cgi?id=380715&action=review > LayoutTests/requestidlecallback/requestidlecallback-is-called-expected.txt:8 > +PASS logs.join(", ") is "1.A1, 2.B1, 4.A2, 3.B2" This ordering is expected in accordance with the specification although this is not what Chrome does. See https://github.com/w3c/requestidlecallback/issues/82
Radar WebKit Bug Importer
Comment 4 2019-10-10 19:27:58 PDT
<rdar://problem/56178321>
EWS Watchlist
Comment 5 2019-10-11 03:35:53 PDT
Comment on attachment 380715 [details] Add the forgotten file Attachment 380715 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13119724 New failing tests: requestidlecallback/requestidlecallback-is-not-called-when-canceled.html requestidlecallback/requestidlecallback-is-called.html
EWS Watchlist
Comment 6 2019-10-11 03:35:57 PDT
Created attachment 380738 [details] Archive of layout-test-results from ews215 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews215 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Ryosuke Niwa
Comment 7 2019-10-11 16:38:16 PDT
Oh, looks like I had failed to enable requestIdleCallback on Windows. That's an orthogonal issue to this patch though. And WK1's test failure seems to be unrelated to this patch.
Antti Koivisto
Comment 8 2019-10-11 22:54:39 PDT
Comment on attachment 380715 [details] Add the forgotten file View in context: https://bugs.webkit.org/attachment.cgi?id=380715&action=review > Source/WebCore/dom/IdleCallbackController.cpp:88 > + auto deadline = now + 50_ms; Where does that 50ms come from?
Ryosuke Niwa
Comment 9 2019-10-12 13:34:09 PDT
Committed r251050: <https://trac.webkit.org/changeset/251050>
Note You need to log in before you can comment on or make changes to this bug.