Bug 203024

Summary:

DumpRenderTree should clear WTFLogChannelState::OnWithAccumulation state set by testRunner.accummulateLogsForChannel

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

WebCore Misc.

Assignee:

Fujii Hironori <fujii.hironori>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, commit-queue, darin, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Fujii Hironori

Reported 2019-10-15 21:06:50 PDT

If a test case calls testRunner.accummulateLogsForChannel("IndexedDB"), all subsequent IndexedDB tests dumps the log. This is bloating DumpRenderTree log because DumpRenderTree is run with --debug-rwt-logging switch. For example, https://build.webkit.org/builders/Apple-Catalina-Debug-WK1-Tests/builds/70/steps/layout-test/logs/stdio testRunner.accummulateLogsForChannel was added by Bug 157274.

Attachments
Patch (7.24 KB, patch) 2019-10-15 21:15 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-10-15 21:08:08 PDT

It is used in the following tests: grep -re accummulateLogsForChannel * storage/indexeddb/modern/resources/256-open-databases.js\04: testRunner.accummulateLogsForChannel("IndexedDB"); storage/indexeddb/modern/resources/abort-requests-cancelled.js\04: testRunner.accummulateLogsForChannel("IndexedDB"); storage/indexeddb/modern/resources/autoincrement-abort.js\07: testRunner.accummulateLogsForChannel("IndexedDB"); storage/indexeddb/resources/intversion-open-in-upgradeneeded.js\09: testRunner.accummulateLogsForChannel("IndexedDB"); storage/indexeddb/resources/odd-strings.js\09: testRunner.accummulateLogsForChannel("IndexedDB");

Fujii Hironori

Comment 2 2019-10-15 21:15:41 PDT

Created attachment 381051 [details] Patch

WebKit Commit Bot

Comment 3 2019-10-16 11:15:08 PDT

Comment on attachment 381051 [details] Patch Clearing flags on attachment: 381051 Committed r251193: <https://trac.webkit.org/changeset/251193>

WebKit Commit Bot

Comment 4 2019-10-16 11:15:10 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2019-10-16 11:16:18 PDT

<rdar://problem/56339259>

Fujii Hironori

Comment 6 2019-10-16 18:57:25 PDT

Thank you very much for r+. I checked the log sizes: r251192: 339348 lines, 25657835 bytes r251193: 73045 lines, 7204035 bytes https://build.webkit.org/builders/Apple-Catalina-Debug-WK1-Tests/builds/117/steps/layout-test/logs/stdio/text https://build.webkit.org/builders/Apple-Catalina-Debug-WK1-Tests/builds/118/steps/layout-test/logs/stdio/text

Note You need to log in before you can comment on or make changes to this bug.