Bug 203140

Summary: Flaky Test: fast/events/resize-subframe-in-rendering-update.html
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: Tools / TestsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, koivisto, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 203384    
Bug Blocks: 50856, 202964    
Attachments:
Description Flags
Archive of layout-test-results from webkit-cq-01
none
Archive of layout-test-results from webkit-cq-03
none
Fixes the test
simon.fraser: review+
Fix the test none

WebKit Commit Bot
Reported 2019-10-17 22:21:14 PDT
This is an automatically generated bug from the commit-queue. fast/events/resize-subframe-in-rendering-update.html has been flaky on the commit-queue. fast/events/resize-subframe-in-rendering-update.html was authored by rniwa@webkit.org. https://trac.webkit.org/browser/trunk/LayoutTests/fast/events/resize-subframe-in-rendering-update.html The commit-queue just saw fast/events/resize-subframe-in-rendering-update.html flake (text diff) while processing attachment 381247 [details] on bug 203021. Bot: webkit-cq-01 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6 The bots will update this with information from each new failure. If you believe this bug to be fixed or invalid, feel free to close. The bots will re-open if the flake re-occurs. If you would like to track this test fix with another bug, please close this bug as a duplicate. The bots will follow the duplicate chain when making future comments.
Attachments
Archive of layout-test-results from webkit-cq-01 (3.46 MB, application/zip)
2019-10-17 22:21 PDT, WebKit Commit Bot 		no flags
Details
Archive of layout-test-results from webkit-cq-03 (3.48 MB, application/zip)
2019-10-18 11:07 PDT, WebKit Commit Bot 		no flags
Details
Fixes the test (2.84 KB, patch)
2019-10-18 12:22 PDT, Ryosuke Niwa 		simon.fraser: review+
DetailsFormatted DiffDiff
Fix the test (2.27 KB, patch)
2019-10-19 15:19 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2019-10-17 22:21:16 PDT
Created attachment 381269 [details] Archive of layout-test-results from webkit-cq-01
WebKit Commit Bot
Comment 2 2019-10-18 11:07:57 PDT
The commit-queue just saw fast/events/resize-subframe-in-rendering-update.html flake (text diff) while processing attachment 381307 [details] on bug 203153. Bot: webkit-cq-03 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.13.6
WebKit Commit Bot
Comment 3 2019-10-18 11:07:58 PDT
Created attachment 381316 [details] Archive of layout-test-results from webkit-cq-03
Ryosuke Niwa
Comment 4 2019-10-18 12:22:53 PDT
Created attachment 381322 [details] Fixes the test
Ryosuke Niwa
Comment 5 2019-10-18 12:43:36 PDT
Thanks for the review!
Ryosuke Niwa
Comment 6 2019-10-18 12:44:24 PDT
Committed r251294: <https://trac.webkit.org/changeset/251294>
Radar WebKit Bug Importer
Comment 7 2019-10-18 12:45:16 PDT
<rdar://problem/56415948>
Alexey Proskuryakov
Comment 8 2019-10-19 12:06:30 PDT
This substantially improved test stability, but it's still failing fairly frequently. https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r251317%20(11394)/fast/events/resize-subframe-in-rendering-update-pretty-diff.html
Ryosuke Niwa
Comment 9 2019-10-19 14:26:16 PDT
(In reply to Alexey Proskuryakov from comment #8) > This substantially improved test stability, but it's still failing fairly > frequently. > > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/r251317%20(11394)/fast/events/ > resize-subframe-in-rendering-update-pretty-diff.html Hm... I did --iterations 100 to make sure it doesn't flake but I guess that was just on my machine.
Ryosuke Niwa
Comment 10 2019-10-19 15:16:08 PDT
Alright, the following command can reproduce the flakiness even on macOS Mojave: ./Tools/Scripts/run-webkit-tests --debug LayoutTests/fast/events/resize-* --iterations 100 --no-show-results --exit-after-n-failures=1 -1 I think the fundamental problem is that there is no way to order requestAnimationFrame and setTimeout deterministically right now. We need to remove the assertion inside setTimeout for now.
Ryosuke Niwa
Comment 11 2019-10-19 15:19:20 PDT
Created attachment 381376 [details] Fix the test
WebKit Commit Bot
Comment 12 2019-10-19 16:50:39 PDT
Comment on attachment 381376 [details] Fix the test Clearing flags on attachment: 381376 Committed r251328: <https://trac.webkit.org/changeset/251328>
WebKit Commit Bot
Comment 13 2019-10-24 15:37:24 PDT
Re-opened since this is blocked by bug 203384
Note You need to log in before you can comment on or make changes to this bug.