Bug 204047

Summary:

Unskip some fetch tests

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

Tools / Tests

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, tsavell, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=204756
https://bugs.webkit.org/show_bug.cgi?id=204757

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Rob Buis

Reported 2019-11-09 06:04:47 PST

Two fetch tests are reported as timing out but do not time out (anymore): # These fetch tests time out -imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-no-load-event.https.html [ Skip ] imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination.https.html [ Skip ] -imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker.html [ Skip ]

Attachments
Patch (4.45 KB, patch) 2019-11-09 06:07 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (4.15 KB, patch) 2019-11-09 08:01 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (5.27 KB, patch) 2019-11-09 08:55 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (5.12 KB, patch) 2019-11-09 09:44 PST, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2019-11-09 06:07:40 PST

Created attachment 383213 [details] Patch

Rob Buis

Comment 2 2019-11-09 08:01:38 PST

Created attachment 383219 [details] Patch

Rob Buis

Comment 3 2019-11-09 08:55:01 PST

Created attachment 383220 [details] Patch

Rob Buis

Comment 4 2019-11-09 09:44:59 PST

Created attachment 383221 [details] Patch

WebKit Commit Bot

Comment 5 2019-11-12 07:24:22 PST

Comment on attachment 383221 [details] Patch Clearing flags on attachment: 383221 Committed r252363: <https://trac.webkit.org/changeset/252363>

WebKit Commit Bot

Comment 6 2019-11-12 07:24:23 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2019-11-12 07:25:17 PST

<rdar://problem/57115612>

Truitt Savell

Comment 8 2019-11-15 07:24:50 PST

Both of these unskipped tests are flakey failures. This one is flakey on iOS imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-no-load-event.https.html This one is flakey on Mac and iOS imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker.html History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fcontent-encoding%2Fbad-gzip-body.any.worker.html&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fapi%2Frequest%2Fdestination%2Ffetch-destination-no-load-event.https.html

Rob Buis

Comment 9 2019-11-15 07:37:15 PST

(In reply to Truitt Savell from comment #8) > Both of these unskipped tests are flakey failures. > > This one is flakey on iOS > imported/w3c/web-platform-tests/fetch/api/request/destination/fetch- > destination-no-load-event.https.html > > This one is flakey on Mac and iOS > imported/w3c/web-platform-tests/fetch/content-encoding/bad-gzip-body.any. > worker.html > > History: > https://results.webkit.org/?suite=layout-tests&suite=layout- > tests&test=imported%2Fw3c%2Fweb-platform-tests%2Ffetch%2Fcontent- > encoding%2Fbad-gzip-body.any.worker.html&test=imported%2Fw3c%2Fweb-platform- > tests%2Ffetch%2Fapi%2Frequest%2Fdestination%2Ffetch-destination-no-load- > event.https.html Sounds like these tests changed from being timeouts to flaky tests at some point. I guess we have the choice of reverting the patch or marking as flaky. WDYT?

Truitt Savell

Comment 10 2019-11-15 09:02:43 PST

I believe having tests is better than not having tests. I think these should be marked as failures and a new bug filed for the failures.

Rob Buis

Comment 11 2019-11-15 09:05:45 PST

(In reply to Truitt Savell from comment #10) > I believe having tests is better than not having tests. I think these should > be marked as failures and a new bug filed for the failures. Sounds good. I am done for the day here in Europe, but if you want I can look into it over the weekend.

Truitt Savell

Comment 12 2019-12-02 10:28:21 PST

Made new bugs and marked the tests as flakey while you are investigating https://bugs.webkit.org/show_bug.cgi?id=204756 https://bugs.webkit.org/show_bug.cgi?id=204757

Note You need to log in before you can comment on or make changes to this bug.