Bug 204169

Summary: Add build flag for stale-while-revalidate
Product: WebKit Reporter: Rob Buis <rbuis>
Component: WebCore Misc.Assignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, cgarcia, commit-queue, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 201461    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2019-11-13 12:08:02 PST
Add build flag for stale-while-revalidate to make it independent from the NETWORK_CACHE_SPECULATIVE_REVALIDATION build flag.
Attachments
Patch (61.34 KB, patch)
2019-11-13 12:12 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (60.45 KB, patch)
2020-01-13 08:08 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (61.32 KB, patch)
2020-01-21 10:20 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (61.36 KB, patch)
2020-01-21 11:07 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (60.63 KB, patch)
2020-01-21 11:56 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2019-11-13 12:12:03 PST
Created attachment 383479 [details] Patch
youenn fablet
Comment 2 2019-11-13 15:22:00 PST
Will NETWORK_CACHE_STALE_WHILE_REVALIDATE without NETWORK_CACHE_SPECULATIVE_REVALIDATION compile?
Rob Buis
Comment 3 2019-11-14 01:45:24 PST
(In reply to youenn fablet from comment #2) > Will NETWORK_CACHE_STALE_WHILE_REVALIDATE without > NETWORK_CACHE_SPECULATIVE_REVALIDATION compile? Yes, I just tried it, and the tests pass as well.
Rob Buis
Comment 4 2020-01-13 08:08:07 PST
Created attachment 387528 [details] Patch
Rob Buis
Comment 5 2020-01-13 09:10:46 PST
Comment on attachment 387528 [details] Patch This still seems useful to me.
youenn fablet
Comment 6 2020-01-21 04:28:47 PST
Comment on attachment 387528 [details] Patch Can you verify this is compiling with the flag off?
Rob Buis
Comment 7 2020-01-21 10:20:12 PST
Created attachment 388316 [details] Patch
Rob Buis
Comment 8 2020-01-21 11:07:09 PST
Created attachment 388325 [details] Patch
Rob Buis
Comment 9 2020-01-21 11:56:52 PST
Created attachment 388330 [details] Patch
Rob Buis
Comment 10 2020-01-21 12:46:27 PST
(In reply to youenn fablet from comment #6) > Comment on attachment 387528 [details] > Patch > > Can you verify this is compiling with the flag off? Good point, there were some unused param errors, fixed now.
WebKit Commit Bot
Comment 11 2020-01-21 14:32:27 PST
The commit-queue encountered the following flaky tests while processing attachment 388330 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 12 2020-01-21 14:33:08 PST
Comment on attachment 388330 [details] Patch Clearing flags on attachment: 388330 Committed r254883: <https://trac.webkit.org/changeset/254883>
WebKit Commit Bot
Comment 13 2020-01-21 14:33:10 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2020-01-21 14:34:20 PST
<rdar://problem/58774042>
Note You need to log in before you can comment on or make changes to this bug.