Bug 204197

Summary: Turn off antialiasing when rendering with Ahem, for testing
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: TextAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, ews-watchlist, gsnedders, mmaxfield, philip, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203750
https://github.com/web-platform-tests/wpt/issues/20058
https://bugs.webkit.org/show_bug.cgi?id=204334
https://bugs.webkit.org/show_bug.cgi?id=204505
Attachments:
Description Flags
Patch
mmaxfield: review+, ews-watchlist: commit-queue-
Patch
none
Archive of layout-test-results from ews213 for win-future
none
Archive of layout-test-results from ews214 for win-future none

Simon Fraser (smfr)
Reported 2019-11-14 08:01:58 PST
We should add a setting to allow Ahem antialiasing to be turned off when running tests. This is necessary to match the behavior of other browsers when running web platform tests.
Attachments
Patch (17.04 KB, patch)
2019-11-19 13:06 PST, Simon Fraser (smfr) 		mmaxfield: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Patch (15.56 KB, patch)
2019-11-19 16:21 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews213 for win-future (14.25 MB, application/zip)
2019-11-19 22:30 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews214 for win-future (14.54 MB, application/zip)
2019-11-20 03:12 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-11-14 08:03:39 PST
<rdar://problem/57190712>
Simon Fraser (smfr)
Comment 2 2019-11-19 13:06:07 PST
Created attachment 383896 [details] Patch
Simon Fraser (smfr)
Comment 3 2019-11-19 16:21:06 PST
Created attachment 383919 [details] Patch
EWS Watchlist
Comment 4 2019-11-19 22:30:48 PST
Comment on attachment 383919 [details] Patch Attachment 383919 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13268555 New failing tests: imported/blink/fast/events/panScroll-crash.html
EWS Watchlist
Comment 5 2019-11-19 22:30:50 PST
Created attachment 383945 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
EWS Watchlist
Comment 6 2019-11-20 03:12:11 PST
Comment on attachment 383896 [details] Patch Attachment 383896 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13268806 New failing tests: fast/dom/domTokenListIterator.html fast/dom/nodeListIterator.html fast/dom/NodeList/nodelist-iterable.html
EWS Watchlist
Comment 7 2019-11-20 03:12:14 PST
Created attachment 383953 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Simon Fraser (smfr)
Comment 8 2019-11-20 10:59:30 PST
*** Bug 203750 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 9 2019-11-20 12:33:46 PST
Comment on attachment 383919 [details] Patch Clearing flags on attachment: 383919 Committed r252701: <https://trac.webkit.org/changeset/252701>
Aakash Jain
Comment 10 2019-11-22 04:04:30 PST
> Committed r252701: <https://trac.webkit.org/changeset/252701> Some tests whose TestExpectations were updated in this commit are still failing on iOS. See Bug 204505.
Sam Sneddon [:gsnedders]
Comment 11 2019-11-26 04:02:36 PST
See also Bug 17086 for earlier discussion about this (with regards to earlier versions of Acid 3), and disagreement between Hixie and Hyatt as to whether disabling Ahem AA makes sense.
Myles C. Maxfield
Comment 12 2019-12-10 16:41:12 PST
(In reply to Sam Sneddon [:gsnedders] from comment #11) > See also Bug 17086 for earlier discussion about this (with regards to > earlier versions of Acid 3), and disagreement between Hixie and Hyatt as to > whether disabling Ahem AA makes sense. I disagree with Hixie's comment in https://bugs.webkit.org/show_bug.cgi?id=17086#c13. Platform antialiasing is complicated, using advanced signal analysis techniques. The result of antialiasing is not always intuitive.
Note You need to log in before you can comment on or make changes to this bug.