Bug 204595

Summary: Update ANGLE
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, annulen, ap, commit-queue, dino, don.olmstead, ews-watchlist, fujii.hironori, graouts, gyuyoung.kim, kbr, kondapallykalyan, ross.kirsling, ryuan.choi, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 204767    
Bug Blocks: 198948    
Attachments:
Description Flags
Update ANGLE
none
Fix test failures on Mac and iOS none

James Darpinian
Reported 2019-11-25 17:41:44 PST
Update ANGLE
Attachments
Update ANGLE (7.48 MB, patch)
2019-11-25 21:32 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Fix test failures on Mac and iOS (7.48 MB, patch)
2019-11-26 17:27 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2019-11-25 21:32:25 PST
Created attachment 384325 [details] Update ANGLE
EWS Watchlist
Comment 2 2019-11-25 21:37:55 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
James Darpinian
Comment 3 2019-11-26 17:27:43 PST
Created attachment 384386 [details] Fix test failures on Mac and iOS
Alex Christensen
Comment 4 2019-12-02 10:27:02 PST
https://trac.webkit.org/changeset/252989/webkit
Radar WebKit Bug Importer
Comment 5 2019-12-02 10:27:26 PST
<rdar://problem/57562162>
Aakash Jain
Comment 6 2019-12-02 13:08:48 PST
(In reply to Alex Christensen from comment #4) > https://trac.webkit.org/changeset/252989/webkit This broke the build for wincairo, as also indicated by EWS. 252989 failed in https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/13803 252988 passed in https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/13802
Aakash Jain
Comment 7 2019-12-02 13:09:38 PST
Relevant error: C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\ANGLE\Headers\GLES2\gl2ext_angle.h(641): fatal error C1083: Cannot open include file: '../GLES3/gl32ext_explicit_context_autogen.inc': No such file or directory
Ross Kirsling
Comment 8 2019-12-02 13:59:55 PST
Verified that it's not just a force clean issue: https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/13814 Going to roll out.
WebKit Commit Bot
Comment 9 2019-12-02 14:01:16 PST
Re-opened since this is blocked by bug 204767
Alex Christensen
Comment 10 2019-12-02 14:02:03 PST
Could someone with a WinCairo setup please figure out how to fix this? I don't have a setup to debug this, and uploading a 7+MB patch to EWS to iterate is not practical
James Darpinian
Comment 11 2019-12-02 14:56:04 PST
I can fix it. Sorry, next time I will not request review until EWS passes. webkit-patch upload asks for review automatically, but I guess there is probably a flag to prevent that.
Ross Kirsling
Comment 12 2019-12-02 14:59:42 PST
Oops, I forgot that rollouts don't auto-commit. Looks like the fix is trivial so I'll commit that instead. It often makes sense to review concurrently with waiting for EWS, but hopefully we can resolve all the detected issues before landing next time. :)
Ross Kirsling
Comment 13 2019-12-02 15:02:25 PST
Committed r253012: <https://trac.webkit.org/changeset/253012>
Note You need to log in before you can comment on or make changes to this bug.