Bug 204847

Summary: Add support for WebIDL set-like forEach
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, hi, joepeck, megan_gardner, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159140    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2019-12-04 03:22:44 PST
Add support for WebIDL set-like forEach
Attachments
Patch (17.08 KB, patch)
2019-12-04 10:03 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (19.61 KB, patch)
2019-12-06 00:32 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (19.67 KB, patch)
2019-12-08 08:15 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (25.70 KB, patch)
2019-12-09 00:05 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-12-04 10:03:08 PST
Created attachment 384823 [details] Patch
youenn fablet
Comment 2 2019-12-04 13:08:36 PST
inspector/debugger/tail-deleted-frames/tail-deleted-frames-this-value.html is failing in Mac-debug-wk1, not Mac-wk1, so probably is fine.
youenn fablet
Comment 3 2019-12-06 00:32:20 PST
Created attachment 384993 [details] Patch
Megan Gardner
Comment 4 2019-12-06 14:47:07 PST
Comment on attachment 384993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384993&action=review This is not my area, but lgtm, but we should probably get Chris or Darin or someone else to review this as well... > Source/WebCore/bindings/js/JSDOMBindingInternals.js:39 > + @getByIdDirectPrivate(this, "backingSet").forEach((value, key, map) => { map? should this be 'set'? > LayoutTests/platform/mac-wk1/TestExpectations:34 > + I'm confused how this was affected at all
youenn fablet
Comment 5 2019-12-08 08:13:56 PST
> > Source/WebCore/bindings/js/JSDOMBindingInternals.js:39 > > + @getByIdDirectPrivate(this, "backingSet").forEach((value, key, map) => { > > map? should this be 'set'? Right, sounds better, should not change the behaviour. > > LayoutTests/platform/mac-wk1/TestExpectations:34 > > + > > I'm confused how this was affected at all I don't know either, I asked Joe and Devin and apparently this depends on which methods are executed or not before or as part of the test. If I remove the JS-built-in for the setlike foreach, the test passes again. Maybe the test should be rewritten to be more robust.
youenn fablet
Comment 6 2019-12-08 08:15:53 PST
Created attachment 385123 [details] Patch
youenn fablet
Comment 7 2019-12-09 00:05:19 PST
Created attachment 385136 [details] Patch
youenn fablet
Comment 8 2019-12-09 01:47:17 PST
Comment on attachment 385136 [details] Patch Worked around the inspector test failure by making the JS builtin working for both setlike and maplike.
youenn fablet
Comment 9 2019-12-13 09:51:06 PST
ping review
WebKit Commit Bot
Comment 10 2019-12-13 12:48:22 PST
The commit-queue encountered the following flaky tests while processing attachment 385136 [details]: imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html bug 205216 (author: dbates@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2019-12-13 12:49:17 PST
Comment on attachment 385136 [details] Patch Clearing flags on attachment: 385136 Committed r253494: <https://trac.webkit.org/changeset/253494>
WebKit Commit Bot
Comment 12 2019-12-13 12:49:19 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2019-12-13 12:50:24 PST
<rdar://problem/57921779>
Note You need to log in before you can comment on or make changes to this bug.