Bug 206259
| Summary: | Regression r254533: iOS and mac build broken | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Jiewen Tan <jiewen_tan> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, ap, jiewen_tan, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206112 | ||
Aakash Jain
r254533 seems to have broken iOS and mac builds.
e.g.:
https://build.webkit.org/builders/Apple%20Mojave%20Debug%20%28Build%29/builds/11790
https://build.webkit.org/builders/Apple%20iOS%2013%20Release%20%28Build%29/builds/3286
Relevant build error:/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.1.sdk/usr/include/objc/runtime.h:634:47: error: reference to 'Protocol' is ambiguous
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryan Haddad
In file included from /Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/DerivedSources/WebKit2/unified-sources/UnifiedSource55.cpp:1:
/Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp:42:17: error: member access into incomplete type 'WebKit::CtapDriver'
m_driver->cancel();
^
In file included from /Volumes/Data/slave/mojave-debug/build/WebKitBuild/Debug/DerivedSources/WebKit2/unified-sources/UnifiedSource55.cpp:1:
In file included from /Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.cpp:27:
/Volumes/Data/slave/mojave-debug/build/Source/WebKit/UIProcess/WebAuthentication/fido/FidoAuthenticator.h:34:7: note: forward declaration of 'WebKit::CtapDriver'
class CtapDriver;
^
Jiewen Tan
Committed r254535: <https://trac.webkit.org/changeset/254535>
Radar WebKit Bug Importer
<rdar://problem/58582018>
Aakash Jain
(In reply to Jiewen Tan from comment #2)
> Committed r254535: <https://trac.webkit.org/changeset/254535>
Build is still broken. e.g.: https://build.webkit.org/builders/Apple-Catalina-Release-Build/builds/2446
Alexey Proskuryakov
Ryan reverted the change and the first build fix attempt.