Bug 206322

Summary: Quote file argument to git check-attr
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: New BugsAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, dbates, ews-watchlist, jbedard, kbr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198948    
Attachments:
Description Flags
Quote file argument
none
Add test none

James Darpinian
Reported 2020-01-15 15:43:59 PST
Quote file argument to git check-attr
Attachments
Quote file argument (1.20 KB, patch)
2020-01-15 15:44 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Add test (4.02 KB, patch)
2020-01-27 13:42 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-01-15 15:44:59 PST
Created attachment 387860 [details] Quote file argument
Alexey Proskuryakov
Comment 2 2020-01-15 17:59:00 PST
Comment on attachment 387860 [details] Quote file argument Can a regression test be created for this? I’m not familiar with prepare-ChangeLig tests.
Jonathan Bedard
Comment 3 2020-01-16 09:46:48 PST
Comment on attachment 387860 [details] Quote file argument View in context: https://bugs.webkit.org/attachment.cgi?id=387860&action=review > Tools/Scripts/prepare-ChangeLog:2140 > + my $command = GIT . " check-attr $attr -- '$file'"; This appears correct, but I'm also curious what made you look into this in the first place. Did you edit a file with a space in the name?
Jonathan Bedard
Comment 4 2020-01-16 09:48:41 PST
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 387860 [details] > Quote file argument > > Can a regression test be created for this? I’m not familiar with > prepare-ChangeLig tests. We should be able to, Tools/Scripts/webkitperl/prepare-ChangeLog_unittest...probably run by test-webkitperl.
James Darpinian
Comment 5 2020-01-27 13:42:42 PST
Created attachment 388898 [details] Add test
James Darpinian
Comment 6 2020-01-27 13:44:54 PST
Comment on attachment 387860 [details] Quote file argument View in context: https://bugs.webkit.org/attachment.cgi?id=387860&action=review Added a test. >> Tools/Scripts/prepare-ChangeLog:2140 >> + my $command = GIT . " check-attr $attr -- '$file'"; > > This appears correct, but I'm also curious what made you look into this in the first place. Did you edit a file with a space in the name? I was updating a third-party dependency, ANGLE, and there's an upstream file with parentheses in the name. Obviously this is not ideal and I can work to rename the upstream file, but this is also a bug that should be fixed.
WebKit Commit Bot
Comment 7 2020-01-28 13:07:52 PST
Comment on attachment 388898 [details] Add test Clearing flags on attachment: 388898 Committed r255272: <https://trac.webkit.org/changeset/255272>
WebKit Commit Bot
Comment 8 2020-01-28 13:07:53 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-01-28 13:08:17 PST
<rdar://problem/58966431>
Darin Adler
Comment 10 2020-02-01 15:41:03 PST
Not to be a jerk about it, but a better fix would work even for the filenames containing a single quote character.
Note You need to log in before you can comment on or make changes to this bug.