Bug 206402

Summary: Setting kVTCompressionPropertyKey_DataRateLimits on RTCVideoEncoderH264 fails
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2020-01-17 00:19:19 PST
Setting kVTCompressionPropertyKey_DataRateLimits on RTCVideoEncoderH264 fails
Attachments
Patch (3.19 KB, patch)
2020-01-17 00:21 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.22 KB, patch)
2020-01-20 00:41 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-01-17 00:21:08 PST
Created attachment 388017 [details] Patch
Eric Carlson
Comment 2 2020-01-17 09:00:24 PST
Comment on attachment 388017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388017&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/helpers.cc:134 > + RTC_LOG(LS_ERROR) << "VTSessionSetProperty failed to set: " << key_string it might be worth also logging 'vtSession' so we know which call was made
youenn fablet
Comment 3 2020-01-20 00:41:11 PST
Created attachment 388213 [details] Patch for landing
WebKit Commit Bot
Comment 4 2020-01-20 01:44:08 PST
The commit-queue encountered the following flaky tests while processing attachment 388213 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-01-20 01:44:38 PST
Comment on attachment 388213 [details] Patch for landing Clearing flags on attachment: 388213 Committed r254815: <https://trac.webkit.org/changeset/254815>
WebKit Commit Bot
Comment 6 2020-01-20 01:44:40 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-01-20 01:45:17 PST
<rdar://problem/58733419>
Note You need to log in before you can comment on or make changes to this bug.