Bug 206894

Summary:

[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, annulen, aperez, commit-queue, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
WIP Patch	none
Patch	none
Patch	none
Patch reland	none

Don Olmstead

Reported 2020-01-28 11:08:29 PST

Use WEBKIT_EXECUTABLE in MiniBrowser

Attachments
WIP Patch (7.53 KB, patch) 2020-02-26 16:08 PST, Don Olmstead	no flags	Details Formatted Diff Diff
WIP Patch (8.21 KB, patch) 2020-02-26 16:14 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (10.50 KB, patch) 2020-02-26 16:42 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (10.51 KB, patch) 2020-02-26 18:09 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch reland (10.39 KB, patch) 2020-04-05 20:20 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2020-02-26 16:08:40 PST Comment hidden (obsolete)

Created attachment 391797 [details] WIP Patch

Don Olmstead

Comment 2 2020-02-26 16:14:24 PST Comment hidden (obsolete)

Created attachment 391801 [details] WIP Patch

Don Olmstead

Comment 3 2020-02-26 16:42:55 PST Comment hidden (obsolete)

Created attachment 391809 [details] Patch

Don Olmstead

Comment 4 2020-02-26 18:09:14 PST

Created attachment 391823 [details] Patch

Adrian Perez

Comment 5 2020-02-27 00:50:46 PST

Comment on attachment 391823 [details] Patch The WPE/GTK parts of the patch look good. The Windows bits also look fine to me but I can't be 100% sure so you might want to have some other pair of eyes glance at it before landing.

WebKit Commit Bot

Comment 6 2020-02-27 06:36:32 PST

The commit-queue encountered the following flaky tests while processing attachment 391823 [details]: editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 7 2020-02-27 06:37:03 PST

Comment on attachment 391823 [details] Patch Clearing flags on attachment: 391823 Committed r257565: <https://trac.webkit.org/changeset/257565>

WebKit Commit Bot

Comment 8 2020-02-27 06:37:05 PST

All reviewed patches have been landed. Closing bug.

Don Olmstead

Comment 9 2020-04-05 20:19:42 PDT

This was rolled out

Don Olmstead

Comment 10 2020-04-05 20:20:05 PDT

Created attachment 395541 [details] Patch reland

Don Olmstead

Comment 11 2020-04-05 21:20:04 PDT

Comment on attachment 395541 [details] Patch reland This fixes the issue with WinCairo that caused the roll out.

EWS

Comment 12 2020-04-05 21:22:09 PDT

Committed r259563: <https://trac.webkit.org/changeset/259563> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395541 [details].

Note You need to log in before you can comment on or make changes to this bug.