Bug 206904

Summary: Crash under com.apple.WebKit.Networking at WebKit: WebKit::WebIDBServer::suspend
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sihui Liu
Reported 2020-01-28 13:07:41 PST
Thread[0] EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS at 0x00000000000000a8) 94 m_isSuspended = true; -> 95 m_server->lock().lock(); 96 m_server->stopDatabaseActivitiesOnMainThread(); 15 WebKit: WebKit::WebIDBServer::suspend(WebKit::WebIDBServer::ShouldForceStop) <== 15 WebKit: WebKit::WebIDBServer::suspend(WebKit::WebIDBServer::ShouldForceStop) 15 WebKit: WebKit::NetworkProcess::prepareToSuspend(bool, WTF::CompletionHandler<void ()>&&) 15 WebKit: void IPC::handleMessageAsync<Messages::NetworkProcess::PrepareToSuspend, WebKit::NetworkProcess, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&)>(IPC::Connection&, IPC::Decoder&, WebKit::NetworkProcess*, void (WebKit::NetworkProcess::*)(bool, WTF::CompletionHandler<void ()>&&)) 15 WebKit: WebKit::NetworkProcess::didReceiveNetworkProcessMessage(IPC::Connection&, IPC::Decoder&)
Attachments
Patch (2.03 KB, patch)
2020-01-28 13:13 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2020-01-28 13:08:10 PST
<rdar://problem/58791603>
Sihui Liu
Comment 2 2020-01-28 13:13:35 PST
Created attachment 389054 [details] Patch
Maciej Stachowiak
Comment 3 2020-01-28 17:02:26 PST
Comment on attachment 389054 [details] Patch r=me (seems like this could block the main thread of the network process though, unless I misunderstand what happens on which thread.
WebKit Commit Bot
Comment 4 2020-01-29 12:21:48 PST
The commit-queue encountered the following flaky tests while processing attachment 389054 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-01-29 12:22:14 PST
The commit-queue encountered the following flaky tests while processing attachment 389054 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) imported/w3c/web-platform-tests/xhr/send-send.any.worker.html bug 206345 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-01-29 12:38:47 PST
Comment on attachment 389054 [details] Patch Clearing flags on attachment: 389054 Committed r255375: <https://trac.webkit.org/changeset/255375>
WebKit Commit Bot
Comment 7 2020-01-29 12:38:48 PST
All reviewed patches have been landed. Closing bug.
Geoffrey Garen
Comment 8 2020-01-29 12:49:05 PST
Can we just initialize m_server directly in the constructor on the main thread, instead of posting a task? Since no tasks have been queued yet, there's nothing to synchronize with yet. Specifically, maybe we can initialize m_server directly, and then post a task to upgradeFilesIfNecessary() (and change IDBServer::IDBServer() not to upgradeFilesIfNecessary(), to avoid I/O on the main thread).
Note You need to log in before you can comment on or make changes to this bug.