Bug 207787

Summary: [Webkit.css] Adding popover style
Product: WebKit Reporter: Zhifei Fang <zhifei_fang>
Component: New BugsAssignee: Zhifei Fang <zhifei_fang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jbedard, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zhifei Fang
Reported 2020-02-14 13:34:53 PST
[Webkit.css] Adding popover style
Attachments
Patch (15.67 KB, patch)
2020-02-14 13:38 PST, Zhifei Fang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhifei Fang
Comment 1 2020-02-14 13:38:50 PST
Created attachment 390807 [details] Patch
Zhifei Fang
Comment 2 2020-02-14 13:39:19 PST
<rdar://problem/59412833>
WebKit Commit Bot
Comment 3 2020-02-17 18:11:48 PST
The commit-queue encountered the following flaky tests while processing attachment 390807 [details]: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2020-02-17 18:11:49 PST
The commit-queue encountered the following flaky tests while processing attachment 390807 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-02-17 19:05:03 PST
Comment on attachment 390807 [details] Patch Clearing flags on attachment: 390807 Committed r256807: <https://trac.webkit.org/changeset/256807>
WebKit Commit Bot
Comment 6 2020-02-17 19:05:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-02-17 19:06:20 PST
<rdar://problem/59535887>
Jonathan Bedard
Comment 8 2020-02-18 15:08:58 PST
I like the idea of a shared pop-over style, I do think that we need to iterate a bit here. The results database uses a different pop-over style at the moment, there are some things I like about that style, some that I like about yours. I like the arrow and shadow (both on the arrow and the pop-over) on this new style better than what the results-database does. I don't like the sharp corners, and I prefer the rounded corners of the results-database. I'm a bit torn on the color. I suppose it's configurable, but it never felt right to me to have the background color of the pop-over be the same as the background color of the site, especially as the pop-overs get bigger. On the other hand, the heavy blurring that the results database does can be distracting.
Note You need to log in before you can comment on or make changes to this bug.