Bug 207904

Summary:

Support in-band metadata cues when loading media in the GPU Process

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, calvaris, cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sam, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Eric Carlson

Reported 2020-02-18 12:51:48 PST

Support in-band metadata cues when loading media in the GPU Process

Attachments
Patch (57.13 KB, patch) 2020-02-19 14:09 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (59.30 KB, patch) 2020-02-19 18:59 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (61.32 KB, patch) 2020-02-19 19:04 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (61.89 KB, patch) 2020-02-20 05:56 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (62.64 KB, patch) 2020-02-20 07:12 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (61.89 KB, patch) 2020-02-20 07:25 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (62.43 KB, patch) 2020-02-20 08:55 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (63.68 KB, patch) 2020-02-20 10:17 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (64.22 KB, patch) 2020-02-20 12:54 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (64.23 KB, patch) 2020-02-20 13:45 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch (64.22 KB, patch) 2020-02-20 18:05 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-02-18 12:52:03 PST

<rdar://problem/59561647>

Eric Carlson

Comment 2 2020-02-19 14:09:33 PST

Created attachment 391199 [details] Patch

Eric Carlson

Comment 3 2020-02-19 18:59:26 PST

Created attachment 391243 [details] Patch

Eric Carlson

Comment 4 2020-02-19 19:04:51 PST

Created attachment 391245 [details] Patch

Eric Carlson

Comment 5 2020-02-20 05:56:36 PST

Created attachment 391282 [details] Patch

Sam Weinig

Comment 6 2020-02-20 06:06:49 PST

Comment on attachment 391282 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391282&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:27 > - CreateMediaPlayer(WebKit::MediaPlayerPrivateRemoteIdentifier id, enum:uint8_t WebCore::MediaPlayerEnums::MediaEngineIdentifier remoteEngineIdentifier, struct WebKit::RemoteMediaPlayerProxyConfiguration proxyConfiguration) -> (struct WebKit::RemoteMediaPlayerConfiguration playerConfiguration) Synchronous > - DeleteMediaPlayer(WebKit::MediaPlayerPrivateRemoteIdentifier id) > + CreateMediaPlayer(WebKit::MediaPlayerPrivateRemoteIdentifier id, enum:uint8_t WebCore::MediaPlayerEnums::MediaEngineIdentifier remoteEngineIdentifier, struct WebKit::RemoteMediaPlayerProxyConfiguration proxyConfiguration) -> (struct WebKit::RemoteMediaPlayerConfiguration playerConfiguration) Async 😘

Eric Carlson

Comment 7 2020-02-20 07:12:42 PST

Created attachment 391284 [details] Patch

Eric Carlson

Comment 8 2020-02-20 07:25:30 PST

Created attachment 391285 [details] Patch

Eric Carlson

Comment 9 2020-02-20 08:55:58 PST

Created attachment 391292 [details] Patch

Eric Carlson

Comment 10 2020-02-20 10:17:36 PST

Created attachment 391300 [details] Patch

Eric Carlson

Comment 11 2020-02-20 12:54:26 PST

Created attachment 391319 [details] Patch

Eric Carlson

Comment 12 2020-02-20 13:45:34 PST

Created attachment 391331 [details] Patch

Dean Jackson

Comment 13 2020-02-20 15:10:57 PST

Comment on attachment 391331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391331&action=review > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:49 > + WEBCORE_EXPORT static NSArray* allowedClassesForNativeValues(); Nit, I think the * goes near the function name. > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm:66 > +SerializedPlatformDataCueMac::~SerializedPlatformDataCueMac() Do you need this here now? Could it just be left out or marked = default? > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm:116 > +NSArray* SerializedPlatformDataCueMac::allowedClassesForNativeValues() Nit: * again (I think... I'm never sure of the rules in .mm files) > Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm:211 > static JSValue *jsValueWithAVMetadataItemInContext(AVMetadataItem *item, JSContext *context) Yeah, I guess it does go on that side. > Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:28 > - CreateMediaPlayer(WebKit::MediaPlayerPrivateRemoteIdentifier id, enum:uint8_t WebCore::MediaPlayerEnums::MediaEngineIdentifier remoteEngineIdentifier, struct WebKit::RemoteMediaPlayerProxyConfiguration proxyConfiguration) -> (struct WebKit::RemoteMediaPlayerConfiguration playerConfiguration) Synchronous > - DeleteMediaPlayer(WebKit::MediaPlayerPrivateRemoteIdentifier id) > + CreateMediaPlayer(WebKit::MediaPlayerPrivateRemoteIdentifier id, enum:uint8_t WebCore::MediaPlayerEnums::MediaEngineIdentifier remoteEngineIdentifier, struct WebKit::RemoteMediaPlayerProxyConfiguration proxyConfiguration) -> (struct WebKit::RemoteMediaPlayerConfiguration playerConfiguration) Async > + DeleteMediaPlayer(WebKit::MediaPlayerPrivateRemoteIdentifier id) Sam already gave you love for this, so I don't need to!

Eric Carlson

Comment 14 2020-02-20 18:01:38 PST

Comment on attachment 391331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391331&action=review Thanks for the review! >> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.h:49 >> + WEBCORE_EXPORT static NSArray* allowedClassesForNativeValues(); > > Nit, I think the * goes near the function name. OMG, this is such a RIDICULOUS "rule"... >> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm:66 >> +SerializedPlatformDataCueMac::~SerializedPlatformDataCueMac() > > Do you need this here now? Could it just be left out or marked = default? Good point! >> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm:116 >> +NSArray* SerializedPlatformDataCueMac::allowedClassesForNativeValues() > > Nit: * again (I think... I'm never sure of the rules in .mm files) :-/ >> Source/WebCore/platform/mac/SerializedPlatformDataCueMac.mm:211 >> static JSValue *jsValueWithAVMetadataItemInContext(AVMetadataItem *item, JSContext *context) > > Yeah, I guess it does go on that side. Ditto >> Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:28 >> + DeleteMediaPlayer(WebKit::MediaPlayerPrivateRemoteIdentifier id) > > Sam already gave you love for this, so I don't need to! :-)

Eric Carlson

Comment 15 2020-02-20 18:05:27 PST

Created attachment 391366 [details] Patch

WebKit Commit Bot

Comment 16 2020-02-20 19:35:10 PST

The commit-queue encountered the following flaky tests while processing attachment 391366 [details]: editing/spelling/spellcheck-paste-continuous-disabled.html bug 208016 (authors: g.czajkowski@samsung.com and mark.lam@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 17 2020-02-20 19:35:55 PST

Comment on attachment 391366 [details] Patch Clearing flags on attachment: 391366 Committed r257125: <https://trac.webkit.org/changeset/257125>

WebKit Commit Bot

Comment 18 2020-02-20 19:35:57 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.