Bug 207977

Summary: NSUserDefaultsSPI.h is copied to an incorrect path
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 207996    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
fix
none
fix none

Per Arne Vollan
Reported 2020-02-19 17:10:52 PST
Rename this file to UserDefaultsSPI.h.
Attachments
Patch (10.21 KB, patch)
2020-02-19 17:18 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
fix (10.38 KB, patch)
2020-02-19 22:00 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
fix (2.25 KB, patch)
2020-02-19 22:59 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2020-02-19 17:18:19 PST
Created attachment 391226 [details] Patch
Per Arne Vollan
Comment 2 2020-02-19 17:19:19 PST
rdar://problem/59609174
Brent Fulgham
Comment 3 2020-02-19 17:22:32 PST
Comment on attachment 391226 [details] Patch r=me
Per Arne Vollan
Comment 4 2020-02-19 17:42:21 PST
Comment on attachment 391226 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 5 2020-02-19 18:43:20 PST
The commit-queue encountered the following flaky tests while processing attachment 391226 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-02-19 18:44:02 PST
Comment on attachment 391226 [details] Patch Clearing flags on attachment: 391226 Committed r257029: <https://trac.webkit.org/changeset/257029>
WebKit Commit Bot
Comment 7 2020-02-19 18:44:04 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2020-02-19 21:51:18 PST
This does not address the radar. The problem is that the header goes into /usr/local/include/ for both mac and iosmac, instead of /usr/local/include/pal/ and /System/iOSSupport/usr/local/include/ respectively.
Alexey Proskuryakov
Comment 9 2020-02-19 22:00:16 PST
Created attachment 391259 [details] fix
Alexey Proskuryakov
Comment 10 2020-02-19 22:19:36 PST
Comment on attachment 391259 [details] fix View in context: https://bugs.webkit.org/attachment.cgi?id=391259&action=review > Source/WebCore/PAL/ChangeLog:9 > + Revert r257029, which was an incorrect attempt to address the issue. Fix it by Something here confused svn-create-patch. Let me try reverting and fixing separately.
Alexey Proskuryakov
Comment 11 2020-02-19 22:59:58 PST
Created attachment 391263 [details] fix
Per Arne Vollan
Comment 12 2020-02-20 07:12:23 PST
Comment on attachment 391263 [details] fix R=me. Thank you for fixing this!
WebKit Commit Bot
Comment 13 2020-02-20 08:22:33 PST
The commit-queue encountered the following flaky tests while processing attachment 391263 [details]: imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html bug 206554 (authors: shvaikalesh@gmail.com and youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 14 2020-02-20 08:23:03 PST
Comment on attachment 391263 [details] fix Clearing flags on attachment: 391263 Committed r257062: <https://trac.webkit.org/changeset/257062>
WebKit Commit Bot
Comment 15 2020-02-20 08:23:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.