Bug 212319

Summary: [GTK4] Implement HTTP auth dialog
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, ews-watchlist, gustavo, svillar
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 212318    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch svillar: review+

Carlos Garcia Campos
Reported 2020-05-24 05:46:12 PDT
.
Attachments
Patch (12.45 KB, patch)
2020-05-27 04:57 PDT, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-05-27 04:57:45 PDT
Created attachment 400321 [details] Patch
EWS Watchlist
Comment 2 2020-05-27 04:58:38 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Sergio Villar Senin
Comment 3 2020-05-28 06:29:10 PDT
Comment on attachment 400321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400321&action=review Awesome! > Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:145 > gtk_widget_set_can_default(button, TRUE); Isn't there an alternative for this on GTK4?
Carlos Garcia Campos
Comment 4 2020-05-28 06:56:40 PDT
(In reply to Sergio Villar Senin from comment #3) > Comment on attachment 400321 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400321&action=review > > Awesome! Thanks for the review! > > Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:145 > > gtk_widget_set_can_default(button, TRUE); > > Isn't there an alternative for this on GTK4? No, can-default property was removed because it's no longer needed.
Carlos Garcia Campos
Comment 5 2020-05-29 02:47:23 PDT
Committed r262287: <https://trac.webkit.org/changeset/262287>
Note You need to log in before you can comment on or make changes to this bug.