Bug 214362

Summary: itsnicethat.com page is sometimes non-scrollable
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: UI EventsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dbates, ews-watchlist, fred.wang, jamesr, koivisto, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214367
Attachments:
Description Flags
Patch
thorton: review+
Patch for EWS ews-feeder: commit-queue-

Simon Fraser (smfr)
Reported 2020-07-15 11:01:08 PDT
itsnicethat.com page is sometimes non-scrollable
Attachments
Patch (19.83 KB, patch)
2020-07-15 11:07 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Patch for EWS (18.96 KB, patch)
2020-07-15 11:24 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-07-15 11:07:30 PDT
Created attachment 404359 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-07-15 11:07:33 PDT
<rdar://problem/65431127>
Tim Horton
Comment 3 2020-07-15 11:11:42 PDT
Comment on attachment 404359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404359&action=review > Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:113 > + if ([self.mask isKindOfClass:[CAShapeLayer class]]) { > + CAShapeLayer *shapeMask = static_cast<CAShapeLayer *>(self.mask); I think you can merge these two lines with a dynamic_objc_cast (same above)
Simon Fraser (smfr)
Comment 4 2020-07-15 11:24:12 PDT
Created attachment 404361 [details] Patch for EWS
EWS
Comment 5 2020-07-15 12:55:13 PDT
Invalid ChangeLog at /Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog
Simon Fraser (smfr)
Comment 6 2020-07-15 13:02:53 PDT
https://trac.webkit.org/changeset/264415/webkit
Note You need to log in before you can comment on or make changes to this bug.