Bug 215946

Summary: AudioParam.value setter should call setValueAtTime(value, now)
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://www.w3.org/TR/webaudio/#dom-audioparam-value
See Also: https://bugs.webkit.org/show_bug.cgi?id=215901
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-08-28 12:57:12 PDT
AudioParam.value setter should call setValueAtTime(value, now), as per: - https://www.w3.org/TR/webaudio/#dom-audioparam-value
Attachments
Patch (31.88 KB, patch)
2020-08-28 13:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-08-28 13:19:33 PDT
Created attachment 407498 [details] Patch
Darin Adler
Comment 2 2020-08-28 14:27:23 PDT
Comment on attachment 407498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407498&action=review > Source/WebCore/Modules/webaudio/AudioParam.cpp:94 > + setValue(value); > + auto result = setValueAtTime(m_value, context().currentTime()); Why call both setValue and setValueAtTime?
EWS
Comment 3 2020-08-28 14:27:33 PDT
Committed r266293: <https://trac.webkit.org/changeset/266293> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407498 [details].
Darin Adler
Comment 4 2020-08-28 14:27:47 PDT
Comment on attachment 407498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407498&action=review >> Source/WebCore/Modules/webaudio/AudioParam.cpp:94 >> + auto result = setValueAtTime(m_value, context().currentTime()); > > Why call both setValue and setValueAtTime? I guess we are using setValue to clamp the value for us.
Radar WebKit Bug Importer
Comment 5 2020-08-28 14:28:18 PDT
<rdar://problem/67961959>
Darin Adler
Comment 6 2020-08-28 14:29:17 PDT
Comment on attachment 407498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407498&action=review >>> Source/WebCore/Modules/webaudio/AudioParam.cpp:94 >>> + auto result = setValueAtTime(m_value, context().currentTime()); >> >> Why call both setValue and setValueAtTime? > > I guess we are using setValue to clamp the value for us. I’m really unclear on whether this is intentional and correct or not. And don’t understand the tests well enough to know if it’s tested.
Note You need to log in before you can comment on or make changes to this bug.