Bug 216721

Summary: Selection API: Extend lifetime of selection live range to preserve expando properties
Product: WebKit Reporter: Darin Adler <darin>
Component: HTML EditingAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, mifenton, rniwa, sam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 216325    
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

Darin Adler
Reported 2020-09-18 18:52:20 PDT
Selection API: Extend lifetime of selection live range to preserve expando properties
Attachments
Patch (14.85 KB, patch)
2020-09-18 18:56 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (8.64 KB, patch)
2020-09-18 19:35 PDT, Darin Adler 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-09-18 18:56:47 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2020-09-18 19:35:28 PDT
Created attachment 409188 [details] Patch
Ryosuke Niwa
Comment 3 2020-09-18 23:43:57 PDT
Comment on attachment 409188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409188&action=review > LayoutTests/editing/selection/expando.html:5 > +function collectGarbage() Why not just include LayoutTests/resources/gc.js? > LayoutTests/editing/selection/expando.html:19 > +var repetitions = 20; Maybe use const? > LayoutTests/editing/selection/expando.html:23 > + var count = 0; Maybe use let? > LayoutTests/editing/selection/expando.html:26 > + var range = document.createRange(); Ditto. > LayoutTests/editing/selection/expando.html:41 > + var count = 0; Ditto. > LayoutTests/editing/selection/expando.html:44 > + getSelection().setBaseAndExtent(document, 0, document, 1); > + getSelection().getRangeAt(0).expando = 1; I think another scenario we should consider is modifying selection after this.
Darin Adler
Comment 4 2020-09-19 07:20:07 PDT
Comment on attachment 409188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409188&action=review >> LayoutTests/editing/selection/expando.html:5 >> +function collectGarbage() > > Why not just include LayoutTests/resources/gc.js? Done. >> LayoutTests/editing/selection/expando.html:19 >> +var repetitions = 20; > > Maybe use const? Done. >> LayoutTests/editing/selection/expando.html:23 >> + var count = 0; > > Maybe use let? Done. >> LayoutTests/editing/selection/expando.html:26 >> + var range = document.createRange(); > > Ditto. Done. >> LayoutTests/editing/selection/expando.html:44 >> + getSelection().getRangeAt(0).expando = 1; > > I think another scenario we should consider is modifying selection after this. OK, will add some more tests for that.
Darin Adler
Comment 5 2020-09-19 07:48:11 PDT
Committed r267313: <https://trac.webkit.org/changeset/267313>
Radar WebKit Bug Importer
Comment 6 2020-09-19 07:49:16 PDT
<rdar://problem/69213554>
Note You need to log in before you can comment on or make changes to this bug.