Bug 217549

Summary:

REGRESSION (r267744): [ Debug WK2 ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html is a constant timeout

Product:

WebKit

Reporter:

Hector Lopez <hector_i_lopez>

Component:

New Bugs

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, darin, ggaren, mark.lam, sam, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=217618
https://bugs.webkit.org/show_bug.cgi?id=217059

Attachments:

Description	Flags
Patch	none

Hector Lopez

Reported 2020-10-09 18:15:31 PDT

fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html Test is a constant timeout according to history on macOS wk2 Debug. First occurrence of a timeout is at r267750 History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fcss-custom-paint%2Fout-of-memory-while-adding-worklet-module.html&platform=mac&style=debug Diff: Yesys go from taking 13 seconds on average to 56 seconds on average.

Attachments
Patch (3.60 KB, patch) 2020-10-14 13:41 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2020-10-12 17:47:23 PDT

*** Bug 217618 has been marked as a duplicate of this bug. ***

Truitt Savell

Comment 2 2020-10-13 12:03:58 PDT

Marked test as timing out while investigating: https://trac.webkit.org/changeset/268403/webkit

Ryan Haddad

Comment 3 2020-10-13 13:29:25 PDT

rdar://70213925

Ryan Haddad

Comment 4 2020-10-13 13:30:44 PDT

Probably related to https://trac.webkit.org/changeset/267744/webkit

Hector Lopez

Comment 5 2020-10-13 18:45:17 PDT

Was able to reproduce timeout on revision r267744 and not on r267743 run-webkit-tests fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html --iterations 1000 --ios-simulator --exit-after-n-failures 3 -f --debug Baseline search path: platform/ios-simulator-wk2 -> platform/ios-simulator -> platform/ios-wk2 -> platform/ios -> platform/wk2 -> generic Running 1 test for iPhone SE running iOS Running 4 WebKitTestRunnerApp.apps in parallel. [4/1000] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html failed unexpectedly (test timed out, test was not run) [4/1000] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html failed unexpectedly (test timed out, test was not run) [4/1000] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html failed unexpectedly (test timed out, test was not run) Exiting early after 3 failures. 3 tests run. 0 tests ran as expected, 3 didn't (997 didn't run): Regressions: Unexpected timeouts (1) fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html [ Timeout ]

Chris Dumez

Comment 6 2020-10-14 13:02:10 PDT

(In reply to Hector Lopez from comment #5) > Was able to reproduce timeout on revision r267744 and not on r267743 > > run-webkit-tests > fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html > --iterations 1000 --ios-simulator --exit-after-n-failures 3 -f --debug > > > Baseline search path: platform/ios-simulator-wk2 -> platform/ios-simulator > -> platform/ios-wk2 -> platform/ios -> platform/wk2 -> generic > > Running 1 test for iPhone SE running iOS > > Running 4 WebKitTestRunnerApp.apps in parallel. > > [4/1000] > fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html failed > unexpectedly (test timed out, test was not run) > [4/1000] > fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html failed > unexpectedly (test timed out, test was not run) > [4/1000] > fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html failed > unexpectedly (test timed out, test was not run) > Exiting early after 3 failures. 3 tests run. > > > 0 tests ran as expected, 3 didn't (997 didn't run): > > > Regressions: Unexpected timeouts (1) > fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html [ > Timeout ] The test expects the addModule() function to throw an exception. However, as of r267744, the addModule() returns a Promise and therefore no longer throws synchronously. The test needs updating.

Chris Dumez

Comment 7 2020-10-14 13:41:26 PDT

Created attachment 411369 [details] Patch

EWS

Comment 8 2020-10-14 14:19:07 PDT

Committed r268488: <https://trac.webkit.org/changeset/268488> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411369 [details].

Note You need to log in before you can comment on or make changes to this bug.