Bug 217720

Summary: [WebAuthn] Remove the "alg" field in the attestation statement
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jiewen_tan, sweeden, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2020-10-14 11:34:11 PDT
Remove the "alg" field in the attestation statement.
Attachments
Patch (3.72 KB, patch)
2020-10-15 13:41 PDT, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (3.68 KB, patch)
2020-10-16 11:31 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-10-15 13:30:51 PDT
<rdar://problem/70349734>
Jiewen Tan
Comment 2 2020-10-15 13:41:10 PDT
Created attachment 411480 [details] Patch
Brent Fulgham
Comment 3 2020-10-16 09:51:59 PDT
Comment on attachment 411480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411480&action=review r=me > Source/WebKit/ChangeLog:13 > + Therefore, remove it to resolve confusions. This should be rephrased: "... to resolve confusion."
Jiewen Tan
Comment 4 2020-10-16 11:27:53 PDT
Comment on attachment 411480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411480&action=review Thanks Brent for r+ this patch. >> Source/WebKit/ChangeLog:13 >> + Therefore, remove it to resolve confusions. > > This should be rephrased: "... to resolve confusion." Fixed.
Jiewen Tan
Comment 5 2020-10-16 11:31:20 PDT
Created attachment 411599 [details] Patch for landing
EWS
Comment 6 2020-10-16 12:20:46 PDT
Committed r268602: <https://trac.webkit.org/changeset/268602> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411599 [details].
Note You need to log in before you can comment on or make changes to this bug.