Bug 217803

Summary: Move even more AudioContext-specific logic out of BaseAudioContext
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 217794    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-10-15 20:14:01 PDT
Move even more AudioContext-specific logic out of BaseAudioContext and into AudioContext. In particular, all the logic related to autoplay restrictions, audible state, and platform media session interruptions only apply to AudioContext and not OfflineAudioContext.
Attachments
Patch (38.06 KB, patch)
2020-10-15 20:18 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (38.02 KB, patch)
2020-10-16 10:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (38.01 KB, patch)
2020-10-16 10:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-15 20:18:02 PDT
Created attachment 411526 [details] Patch
Eric Carlson
Comment 2 2020-10-16 08:18:25 PDT
Comment on attachment 411526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411526&action=review > Source/WebCore/Modules/webaudio/AudioContext.cpp:390 > + RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Suspending playback after going to the background"); Any reason to not use `ALWAYS_LOG(LOGIDENTIFIER, ...)` so the output is in the same format as the rest of the logging from this class? > Source/WebCore/Modules/webaudio/AudioContext.cpp:395 > + RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Resuming playback after entering foreground"); Ditto.
Chris Dumez
Comment 3 2020-10-16 10:01:23 PDT
Created attachment 411590 [details] Patch
EWS
Comment 4 2020-10-16 10:10:31 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Chris Dumez
Comment 5 2020-10-16 10:59:47 PDT
Created attachment 411596 [details] Patch
EWS
Comment 6 2020-10-16 11:32:05 PDT
Committed r268600: <https://trac.webkit.org/changeset/268600> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411596 [details].
Radar WebKit Bug Importer
Comment 7 2020-10-16 11:33:16 PDT
<rdar://problem/70385620>
Note You need to log in before you can comment on or make changes to this bug.