Bug 218070

Summary: [WebAuthn] Make WebContent process talk to the WebAuthn process for WebAuthn requests
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2020-10-21 22:44:15 PDT
Make WebContent process talk to the WebAuthn process for WebAuthn requests.
Attachments
Patch (55.08 KB, patch)
2020-10-21 22:55 PDT, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (55.11 KB, patch)
2020-10-29 13:27 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2020-10-21 22:44:30 PDT
<rdar://problem/70384404>
Jiewen Tan
Comment 2 2020-10-21 22:55:08 PDT
Created attachment 412069 [details] Patch
Brent Fulgham
Comment 3 2020-10-29 10:33:24 PDT
Comment on attachment 412069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412069&action=review I had a few suggestions, but looks good. r=me > Source/WebKit/Scripts/process-entitlements.sh:317 > +# elif [[ "${PRODUCT_NAME}" == com.apple.WebKit.WebAuthn ]]; then ios_family_process_webauthn_entitlements Did you mean to have this commented out? If so, please include a # FIXME() comment with the bug number to enable it. > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:168 > + // If so, continue to the old route. Otherwise, use the modern WebAuthn process way. I suggest a FIXME bug here to remove this code once we cut-over to the modern WebAuthn process.
Jiewen Tan
Comment 4 2020-10-29 13:24:22 PDT
Comment on attachment 412069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412069&action=review Thanks Brent for r+ this patch. >> Source/WebKit/Scripts/process-entitlements.sh:317 >> +# elif [[ "${PRODUCT_NAME}" == com.apple.WebKit.WebAuthn ]]; then ios_family_process_webauthn_entitlements > > Did you mean to have this commented out? > > If so, please include a # FIXME() comment with the bug number to enable it. Just forgot to uncomment it... Good catch! >> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:168 >> + // If so, continue to the old route. Otherwise, use the modern WebAuthn process way. > > I suggest a FIXME bug here to remove this code once we cut-over to the modern WebAuthn process. Fixed. rdar://problem/70822834
Jiewen Tan
Comment 5 2020-10-29 13:27:47 PDT
Created attachment 412679 [details] Patch for landing
EWS
Comment 6 2020-10-29 14:10:15 PDT
Committed r269168: <https://trac.webkit.org/changeset/269168> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412679 [details].
Note You need to log in before you can comment on or make changes to this bug.