Bug 220236

Summary: WebKit IPC generator tests have duplicate receiver names, limiting the implementation
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebKit2Assignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Minor CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 217211, 220318    
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2021-01-04 03:20:39 PST
WebKit IPC generator tests have duplicate receiver names, limiting the implementation This is a problem because in real world usage, all the receiver names need to be unique. The in the test content, there is 3 different receivers receivers. They also share names of the messages. These distinct messages get assigned the same message name, even though the messages themselves are distinct and have different receivers and maybe arguments.
Attachments
Patch (257.64 KB, patch)
2021-01-04 05:50 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-01-04 05:50:07 PST
Created attachment 416935 [details] Patch
Chris Dumez
Comment 2 2021-01-05 12:19:58 PST
Comment on attachment 416935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416935&action=review r=me > Source/WebKit/Scripts/MessageNames.h:-31 > -enum class ReceiverName : uint8_t { Having WebPage 3 times in this enum indeed seemed bogus.
EWS
Comment 3 2021-01-05 16:45:18 PST
Committed r271183: <https://trac.webkit.org/changeset/271183> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416935 [details].
Radar WebKit Bug Importer
Comment 4 2021-01-05 16:46:16 PST
<rdar://problem/72834703>
Note You need to log in before you can comment on or make changes to this bug.