Bug 221125

Summary: [WebAuthn] Optimize _WKWebAuthenticationPanelDelegate for native API
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2021-01-29 00:41:21 PST
Optimize _WKWebAuthenticationPanelDelegate for native API.
Attachments
Patch (37.45 KB, patch)
2021-01-29 00:54 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (37.54 KB, patch)
2021-01-29 17:05 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (43.04 KB, patch)
2021-01-29 22:19 PST, Jiewen Tan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (43.38 KB, patch)
2021-01-29 22:26 PST, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (43.36 KB, patch)
2021-02-01 16:02 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2021-01-29 00:41:36 PST
<rdar://problem/71509141>
Jiewen Tan
Comment 2 2021-01-29 00:54:46 PST
Created attachment 418711 [details] Patch
Jiewen Tan
Comment 3 2021-01-29 17:05:08 PST
Created attachment 418789 [details] Patch
Jiewen Tan
Comment 4 2021-01-29 22:19:02 PST
Created attachment 418808 [details] Patch
Jiewen Tan
Comment 5 2021-01-29 22:26:38 PST
Created attachment 418809 [details] Patch
Brent Fulgham
Comment 6 2021-02-01 15:38:24 PST
Comment on attachment 418809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418809&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:509 > + RunLoop::main().dispatch([weakPanel, call = WTFMove(call)] () { Should we WTFMove() the weakPanel? We don't use it again outside the dispatch. > Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:155 > + [responses[0] setLAContext:laContext.get()]; Why not responses.firstObject?
Jiewen Tan
Comment 7 2021-02-01 15:47:24 PST
Comment on attachment 418809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418809&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:509 >> + RunLoop::main().dispatch([weakPanel, call = WTFMove(call)] () { > > Should we WTFMove() the weakPanel? We don't use it again outside the dispatch. Good catch. We can totally move that. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:155 >> + [responses[0] setLAContext:laContext.get()]; > > Why not responses.firstObject? Sure, it's totally doable. Since we check the count before, [0] shouldn't cause any issue.
Jiewen Tan
Comment 8 2021-02-01 16:02:15 PST
Created attachment 418937 [details] Patch for landing
EWS
Comment 9 2021-02-01 18:50:06 PST
Committed r272184: <https://trac.webkit.org/changeset/272184> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418937 [details].
Note You need to log in before you can comment on or make changes to this bug.