Bug 221405

Summary: Improve percentage height in shouldComputeLogicalWidthFromAspectRatio
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 47738    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2021-02-04 06:32:30 PST
Make shouldComputeLogicalWidthFromAspectRatio check percentage height better.
Attachments
Patch (4.36 KB, patch)
2021-02-04 06:33 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (4.55 KB, patch)
2021-02-05 13:24 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (4.59 KB, patch)
2021-02-17 01:11 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2021-02-04 06:33:51 PST
Created attachment 419278 [details] Patch
Rob Buis
Comment 2 2021-02-05 13:24:24 PST
Created attachment 419454 [details] Patch
Radar WebKit Bug Importer
Comment 3 2021-02-11 06:33:17 PST
<rdar://problem/74232105>
Simon Fraser (smfr)
Comment 4 2021-02-16 14:49:52 PST
Comment on attachment 419454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419454&action=review > Source/WebCore/rendering/RenderBox.cpp:5092 > + if (!shouldComputeLogicalWidthFromAspectRatioAndInsets() && !style().logicalHeight().isFixed() && !(style().logicalHeight().isPercentOrCalculated() && (isOutOfFlowPositioned() || percentageLogicalHeightIsResolvable()))) That list of conditions is getting pretty complex. Maybe wrap it in a lambda for clarity.
Rob Buis
Comment 5 2021-02-17 01:11:29 PST
Created attachment 420613 [details] Patch
EWS
Comment 6 2021-02-17 02:38:00 PST
Committed r272992: <https://commits.webkit.org/r272992> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420613 [details].
Note You need to log in before you can comment on or make changes to this bug.