Bug 221753

Summary: Remove FontSelector dependence in CSSFontFace when creating a new FontFace wrapper
Product: WebKit Reporter: Chris Lord <clord>
Component: WebCore Misc.Assignee: Chris Lord <clord>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208351    
Attachments:
Description Flags
Patch
none
Patch none

Chris Lord
Reported 2021-02-11 06:53:16 PST
As part of the work of removing the m_fontSelector member in CSSFontFace, we can remove a use of it when creating a FontFace wrapper by adding a parameter to provide the script execution context (which is the actual dependence, via FontSelector::document()).
Attachments
Patch (6.47 KB, patch)
2021-02-11 06:57 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Patch (6.47 KB, patch)
2021-02-11 07:23 PST, Chris Lord 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2021-02-11 06:57:53 PST
Created attachment 419984 [details] Patch
Myles C. Maxfield
Comment 2 2021-02-11 07:07:57 PST
Comment on attachment 419984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419984&action=review > Source/WebCore/css/FontFace.h:58 > + static Ref<FontFace> create(ScriptExecutionContext*, CSSFontFace&); How come this change doesn’t have an accompanying IDL change?
Myles C. Maxfield
Comment 3 2021-02-11 07:08:11 PST
Comment on attachment 419984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419984&action=review > Source/WebCore/css/FontFace.h:58 > + static Ref<FontFace> create(ScriptExecutionContext*, CSSFontFace&); How come this change doesn’t have an accompanying IDL change?
Chris Lord
Comment 4 2021-02-11 07:21:43 PST
(In reply to Myles C. Maxfield from comment #3) > Comment on attachment 419984 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419984&action=review > > > Source/WebCore/css/FontFace.h:58 > > + static Ref<FontFace> create(ScriptExecutionContext*, CSSFontFace&); > > How come this change doesn’t have an accompanying IDL change? This constructor doesn't feature in the idl and the one that does remains unchanged.
Chris Lord
Comment 5 2021-02-11 07:23:32 PST
Created attachment 419986 [details] Patch
EWS
Comment 6 2021-02-11 08:06:13 PST
Committed r272727: <https://commits.webkit.org/r272727> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419986 [details].
Radar WebKit Bug Importer
Comment 7 2021-02-11 08:07:15 PST
<rdar://problem/74234470>
Note You need to log in before you can comment on or make changes to this bug.