Bug 225512

Summary: [GTK] Use always async scrolling in accelerated compositing mode
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: alex, berto, bugs-noreply, cmarcelo, commit-queue, ews-watchlist, fujii.hironori, gustavo, gyuyoung.kim, luiz, ryuan.choi, sergio, zdobersek, zeno
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 225740    
Bug Blocks: 245783    
Attachments:
Description Flags
Patch fujii.hironori: review+

Carlos Garcia Campos
Reported 2021-05-07 07:48:27 PDT
We currently use async scrolling only when the hardware acceleration policy is set for always, but not when entering accelerating compositing mode in ondemand policy.
Attachments
Patch (7.61 KB, patch)
2021-05-07 07:53 PDT, Carlos Garcia Campos 		fujii.hironori: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-05-07 07:53:18 PDT
Created attachment 427996 [details] Patch
EWS Watchlist
Comment 2 2021-05-07 07:54:10 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Fujii Hironori
Comment 3 2021-05-09 19:12:45 PDT
Comment on attachment 427996 [details] Patch Honestly speaking I prefer the approach doing that in WebPage without platfrom #if (attachment#420247 [details]) rather than in DrawingAreaCoordinatedGraphics with #if PLATFORM(GTK). But, I don't have time to Bug 225512 now. And, I admit it's a good idea not changing Cocoa-port code for this.
Fujii Hironori
Comment 4 2021-05-09 19:13:54 PDT
*** Bug 221067 has been marked as a duplicate of this bug. ***
Carlos Garcia Campos
Comment 5 2021-05-10 00:39:40 PDT
(In reply to Fujii Hironori from comment #3) > Comment on attachment 427996 [details] > Patch > > Honestly speaking I prefer the approach doing that in WebPage without > platfrom #if (attachment#420247 [details]) rather than in > DrawingAreaCoordinatedGraphics with #if PLATFORM(GTK). > But, I don't have time to Bug 225512 now. And, I admit it's a good idea not > changing Cocoa-port code for this. Problem is that enter/exit in WebPage doesn't seem to be balanced, enter can be called more than once, and I've seen also exit/enter calls that don't really exit and enter the AC mode. That doesn't happen with the enter/exit calls in DrawingArea.
Carlos Garcia Campos
Comment 6 2021-05-10 02:14:04 PDT
Committed r277258 (237527@main): <https://commits.webkit.org/237527@main>
WebKit Commit Bot
Comment 7 2021-05-13 02:47:20 PDT
Re-opened since this is blocked by bug 225740
Carlos Garcia Campos
Comment 8 2021-05-13 02:49:48 PDT
This is not so easy in the end. with the patch we are now causing that pages enter in Ac mode when there's an iframe, for example, because async frame scrolling is enabled. I need to investigate this further.
Alejandro G. Castro
Comment 9 2021-05-13 03:53:46 PDT
Chris and me are working in checking some regressions since I activated the async mode in WPE testing by default (bug 224596), the problem can be related. Can you send more information of the failures you are seeing?
Carlos Garcia Campos
Comment 10 2021-05-13 04:57:16 PDT
See https://bugs.webkit.org/show_bug.cgi?id=225644. But the test failure is not the only issue I've noticed, as I said before.
Note You need to log in before you can comment on or make changes to this bug.