Bug 227725

Summary: SubtleCrypto should only be exposed to secure contexts
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, darin, esprehn+autocc, ews-watchlist, ggaren, jiewen_tan, katherine_cheney, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 227737    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-07-06 15:09:33 PDT
SubtleCrypto should only be exposed to secure contexts: - https://www.w3.org/TR/WebCryptoAPI/#dfn-Crypto Gecko and Blink match the specification. This is causing WebKit to fail the WebCryptoAPI/historical.any.html WPT test.
Attachments
Patch (5.03 KB, patch)
2021-07-06 15:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-07-06 15:39:26 PDT
Created attachment 432984 [details] Patch
EWS
Comment 2 2021-07-06 16:55:01 PDT
Committed r279628 (239446@main): <https://commits.webkit.org/239446@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432984 [details].
Radar WebKit Bug Importer
Comment 3 2021-07-06 16:56:18 PDT
<rdar://problem/80238331>
Alexey Proskuryakov
Comment 4 2021-07-06 19:39:59 PDT
This is a case of making things strictly worse because of someone else’s agenda.
WebKit Commit Bot
Comment 5 2021-07-06 23:03:59 PDT
Re-opened since this is blocked by bug 227737
Chris Dumez
Comment 6 2021-07-07 08:37:36 PDT
Committed r279642 (239455@main): <https://commits.webkit.org/239455@main>
Sam Sneddon [:gsnedders]
Comment 7 2021-08-17 10:54:26 PDT
*** Bug 166959 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.