Bug 228894

Summary: [:has() pseudo-class] Basic support
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 227702    
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2021-08-07 03:17:44 PDT
Basic support for https://drafts.csswg.org/selectors/#has-pseudo
Attachments
patch (51.93 KB, patch)
2021-08-07 03:32 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-08-07 03:32:46 PDT
Created attachment 435126 [details] patch
Simon Fraser (smfr)
Comment 2 2021-08-08 08:54:15 PDT
Comment on attachment 435126 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=435126&action=review > Source/WebCore/css/parser/CSSSelectorParser.cpp:286 > + if (hasScopePseudoClass(*end)) Is end always non-null here?
Antti Koivisto
Comment 3 2021-08-08 09:01:46 PDT
Comment on attachment 435126 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=435126&action=review >> Source/WebCore/css/parser/CSSSelectorParser.cpp:286 >> + if (hasScopePseudoClass(*end)) > > Is end always non-null here? yeah, the while() condition checks it
Radar WebKit Bug Importer
Comment 4 2021-08-14 03:18:19 PDT
<rdar://problem/81933618>
EWS
Comment 5 2021-08-19 22:15:55 PDT
Committed r281295 (240719@main): <https://commits.webkit.org/240719@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435126 [details].
Note You need to log in before you can comment on or make changes to this bug.