Bug 230347

Summary: box-shadow and text-shadow do not yield float values while interpolating
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, clopez, dino, ehutchison, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, mifenton, mmaxfield, ntim, pdr, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/30888
Bug Depends on:    
Bug Blocks: 230404    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
simon.fraser: review+
Patch for landing
none
Patch for landing none

Antoine Quint
Reported 2021-09-16 07:00:48 PDT
box-shadow and text-shadow do not yield float values while interpolating
Attachments
Patch (77.57 KB, patch)
2021-09-16 07:02 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (77.89 KB, patch)
2021-09-17 06:55 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (89.95 KB, patch)
2021-09-20 08:29 PDT, Antoine Quint 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch for landing (90.65 KB, patch)
2021-09-20 10:12 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (92.17 KB, patch)
2021-10-18 08:35 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-09-16 07:02:48 PDT
Created attachment 438345 [details] Patch
EWS Watchlist
Comment 2 2021-09-16 07:05:00 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Antoine Quint
Comment 3 2021-09-16 07:12:35 PDT
Filed https://github.com/web-platform-tests/wpt/pull/30823 for the WPT changes.
Antoine Quint
Comment 4 2021-09-17 06:55:53 PDT
Created attachment 438468 [details] Patch
Antoine Quint
Comment 5 2021-09-20 08:29:05 PDT
Created attachment 438681 [details] Patch
Simon Fraser (smfr)
Comment 6 2021-09-20 08:41:45 PDT
Comment on attachment 438681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438681&action=review > Source/WebCore/rendering/TextDecorationPainter.cpp:258 > + int shadowX = LayoutUnit(m_isHorizontal ? shadow->x().value() : shadow->y().value()); > + int shadowY = LayoutUnit(m_isHorizontal ? shadow->y().value() : -shadow->x().value()); These should be floats. Maybe we should even pixel snap them (not necessary for t his patch). > Source/WebCore/rendering/TextDecorationPainter.cpp:278 > + int shadowX = LayoutUnit(m_isHorizontal ? shadow->x().value() : shadow->y().value()); > + int shadowY = LayoutUnit(m_isHorizontal ? shadow->y().value() : -shadow->x().value()); Same.
Antoine Quint
Comment 7 2021-09-20 10:12:49 PDT
Created attachment 438690 [details] Patch for landing
Antoine Quint
Comment 8 2021-09-20 12:24:09 PDT
Committed r282768 (241903@main): <https://commits.webkit.org/241903@main>
Radar WebKit Bug Importer
Comment 9 2021-09-20 12:25:16 PDT
<rdar://problem/83319111>
Eric Hutchison
Comment 10 2021-09-21 10:26:30 PDT
Reverted r282768 for reason: Slowdown on Mac EWS builders as a constant failure. Committed r282826 (241957@main): <https://commits.webkit.org/241957@main>
Antoine Quint
Comment 11 2021-10-18 08:35:05 PDT
Created attachment 441605 [details] Patch for landing
EWS
Comment 12 2021-10-18 23:46:08 PDT
Committed r284437 (243199@main): <https://commits.webkit.org/243199@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441605 [details].
Note You need to log in before you can comment on or make changes to this bug.