Bug 23062

Summary: [jsfunfuzz] Computed exception offset wrong when first instruction is attempt to resolve deleted eval
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 13638    
Attachments:
Description Flags
Emit expression info for the eval resolve barraclough: review+

Oliver Hunt
Reported 2008-12-31 17:44:25 PST
delete eval; (function(){ try { eval("") } catch(e) { print("ARGHH!!!") } })() Results in an assertion failure as it fails to find the correct handler offset when resolving eval fails.
Attachments
Emit expression info for the eval resolve (3.57 KB, patch)
2008-12-31 18:24 PST, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2008-12-31 18:07:48 PST
Have fix, we weren't correctly emitting position information for the resolve of "eval" in the eval call node. Just making tests.
Oliver Hunt
Comment 2 2008-12-31 18:24:21 PST
Created attachment 26342 [details] Emit expression info for the eval resolve Nice and easy fix
Oliver Hunt
Comment 3 2008-12-31 18:34:14 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/parser/Nodes.cpp M LayoutTests/ChangeLog M LayoutTests/fast/js/exception-linenums-expected.txt M LayoutTests/fast/js/resources/exception-linenums.js Committed r39533
Note You need to log in before you can comment on or make changes to this bug.