Bug 230845

Summary: Remove Node::deprecatedIsInert
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, koivisto, rniwa, simon.fraser, webkit-bug-importer, witty.moon7410
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84635, 165279    
Attachments:
Description Flags
Patch
koivisto: review+, ews-feeder: commit-queue-
[fast-cq] Patch none

Tim Nguyen (:ntim)
Reported 2021-09-27 09:26:39 PDT
There's a invalidation bug in the cached computed style preventing the only usage of Node::deprecatedIsInert in Element::isFocusable in favor of RenderStyle::effectiveInert.
Attachments
Patch (10.35 KB, patch)
2022-02-01 01:22 PST, Tim Nguyen (:ntim) 		koivisto: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq] Patch (15.06 KB, patch)
2022-02-26 02:34 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-01 02:21:24 PDT
<rdar://problem/83757966>
Ryosuke Niwa
Comment 2 2022-01-02 18:19:58 PST
yeah, I don't think we should do this. This would require that Element::isFocusable() to rely on the latest style information. That's not tenable given this function needs to be fast and avoid style recalc. I really don't think we should have designed the concept of inert to rely on style resolution at all.
Tim Nguyen (:ntim)
Comment 3 2022-01-30 10:42:02 PST
(In reply to Ryosuke Niwa from comment #2) > yeah, I don't think we should do this. This would require that > Element::isFocusable() to rely on the latest style information. That's not > tenable given this function needs to be fast and avoid style recalc. > > I really don't think we should have designed the concept of inert to rely on > style resolution at all. The idea is to re-use isVisibleWithoutResolvingFullStyle (used by isFocusable), which does not resolve the full style. The problem is that the style is not invalidated correctly in some cases. https://webkit-search.igalia.com/webkit/rev/fb57dd12e0db42483fce7f5e75a2e4ab66ae11a9/Source/WebCore/dom/Element.cpp#3553 So we already consult the style right now in Element::isFocusable for display/visibility, this would just add effectiveInert in it. I don't think this would be slower, since the style is already consulted for those 2 properties anyway.
Tim Nguyen (:ntim)
Comment 4 2022-01-30 10:43:59 PST
I would argue this would be faster, since effectiveInert is just a style bit that can be looked at once we consulted the style for display/visibility, while Node::deprecatedIsInert requires some DOM tree walks.
Tim Nguyen (:ntim)
Comment 5 2022-02-01 01:22:18 PST
Created attachment 450506 [details] Patch
Antti Koivisto
Comment 6 2022-02-01 01:31:11 PST
Comment on attachment 450506 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450506&action=review > LayoutTests/imported/w3c/ChangeLog:9 > + This change unfortunately regresses focusability state when dynamically setting inert, due to a cached > + computed style invalidation bug. Can you also explain why these regressions are minor in practice?
Tim Nguyen (:ntim)
Comment 7 2022-02-26 02:34:25 PST
Created attachment 453290 [details] [fast-cq] Patch
EWS
Comment 8 2022-02-26 23:07:49 PST
Committed r290554 (247832@main): <https://commits.webkit.org/247832@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453290 [details].
Tim Nguyen (:ntim)
Comment 9 2022-02-27 01:48:29 PST
This actually fixed bug 237054!
Tim Nguyen (:ntim)
Comment 10 2022-02-27 01:49:07 PST
*** Bug 237054 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.