Bug 231251

Summary:

Add back RetainPtrARC and TypeCastsCocoaARC tests to TestWTF

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ayumi_kojima, benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=231819

Bug Depends on:

230406, 231172

Bug Blocks:

231467

Attachments:

Description	Flags
Patch v1	darin: review+
Patch for landing	none

David Kilzer (:ddkilzer)

Reported 2021-10-05 14:01:18 PDT

Add back RetainPtrARC and TypeCastsCocoaARC tests to TestWTF. They were removed for: Bug 230406: WTF::RetainPtr<> allows assignment of two pointer types that are not assignable They were removed to make the bots green again: Bug 231172: REGRESSION (r283476): [ iOS macOS Debug ] TestWTF failures in RetainPtrARC and TypeCastsCocoaARC

Attachments
Patch v1 (28.34 KB, patch) 2021-10-06 16:44 PDT, David Kilzer (:ddkilzer)	darin: review+	Details Formatted Diff Diff
Patch for landing (27.17 KB, patch) 2021-10-06 18:37 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-10-05 14:02:19 PDT

<rdar://problem/83902809>

David Kilzer (:ddkilzer)

Comment 2 2021-10-06 08:55:06 PDT

See test failures here: <https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWTF.TypeCastsCocoaARC.dynamic_objc_cast_RetainPtr&test=TestWTF.TypeCastsCocoaARC.dynamic_objc_cast&test=TestWTF.TypeCastsCocoaARC.checked_objc_cast&test=TestWTF.TypeCastsCocoaARC.bridge_id_cast&test=TestWTF.RetainPtrARC.RetainPtrNS&test=TestWTF.RetainPtrARC.AdoptNS>

David Kilzer (:ddkilzer)

Comment 3 2021-10-06 16:44:13 PDT

Created attachment 440455 [details] Patch v1

Darin Adler

Comment 4 2021-10-06 18:24:02 PDT

Comment on attachment 440455 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=440455&action=review Nice solution. > Source/WTF/ChangeLog:12 > + * wtf/cocoa/TypeCastsCocoa.h: > + (checked_objc_castArc): > + - Change `checked_objc_castARC` to `checked_objc_castArc` to > + match `adoptNSArc`. Nice to match, but not sure why Chris decided to turn ARC into a word. > Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:38 > +#define TEST_WTF_BEGIN_AUTORELEASEPOOL @autoreleasepool { I suggest a name like: BEGIN_AUTORELEASEPOOL_FOR_ARC_DEBUG I understand the concept of using "WTF" to avoid conflicts, and "TEST", but I don’t think either are needed in practice.

David Kilzer (:ddkilzer)

Comment 5 2021-10-06 18:33:33 PDT

Comment on attachment 440455 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=440455&action=review >> Source/WTF/ChangeLog:12 >> + match `adoptNSArc`. > > Nice to match, but not sure why Chris decided to turn ARC into a word. I'll revert this change for the final patch. >> Tools/TestWebKitAPI/Tests/WTF/cocoa/TypeCastsCocoa.mm:38 >> +#define TEST_WTF_BEGIN_AUTORELEASEPOOL @autoreleasepool { > > I suggest a name like: BEGIN_AUTORELEASEPOOL_FOR_ARC_DEBUG > > I understand the concept of using "WTF" to avoid conflicts, and "TEST", but I don’t think either are needed in practice. Will do.

David Kilzer (:ddkilzer)

Comment 6 2021-10-06 18:37:06 PDT

Created attachment 440462 [details] Patch for landing

EWS

Comment 7 2021-10-07 08:02:31 PDT

Committed r283712 (242638@main): <https://commits.webkit.org/242638@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440462 [details].

Note You need to log in before you can comment on or make changes to this bug.