Bug 232911

Summary: Enable dialog tests on Windows
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Tools / TestsAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 232926    
Bug Blocks: 84635    
Attachments:
Description Flags
Patch
none
Patch none

Tim Nguyen (:ntim)
Reported 2021-11-09 15:59:59 PST
Lots of tests were skipped because of "dialog.showModal() is undefined" Presumably https://webkit-search.igalia.com/webkit/source/Source/WebCore/page/RuntimeEnabledFeatures.h#295 needs flipping
Attachments
Patch (4.06 KB, patch)
2021-11-09 16:10 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (3.65 KB, patch)
2021-11-09 22:33 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-11-09 16:10:00 PST
Created attachment 443744 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2021-11-09 22:33:49 PST
Created attachment 443776 [details] Patch
youenn fablet
Comment 3 2021-11-09 23:28:31 PST
Comment on attachment 443776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443776&action=review > Source/WebCore/page/RuntimeEnabledFeatures.h:295 > + bool m_dialogElementEnabled { true }; It does not seem a runtime flag is needed here. Can we instead move from a runtime flag to a settings in WebPreferencesExperimental?
Tim Nguyen (:ntim)
Comment 4 2021-11-09 23:34:42 PST
(In reply to youenn fablet from comment #3) > Comment on attachment 443776 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443776&action=review > > > Source/WebCore/page/RuntimeEnabledFeatures.h:295 > > + bool m_dialogElementEnabled { true }; > > It does not seem a runtime flag is needed here. > Can we instead move from a runtime flag to a settings in > WebPreferencesExperimental? It already exists: https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml#439-451
youenn fablet
Comment 5 2021-11-10 00:44:35 PST
Comment on attachment 443776 [details] Patch It would be nice to move to a Settings, can we file a bug to track this one?
EWS
Comment 6 2021-11-10 01:30:36 PST
Committed r285569 (244077@main): <https://commits.webkit.org/244077@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443776 [details].
Radar WebKit Bug Importer
Comment 7 2021-11-10 01:31:23 PST
<rdar://problem/85244734>
Note You need to log in before you can comment on or make changes to this bug.