Bug 233114

Summary: Fingers down on the trackpad should stop an animated scroll
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2021-11-14 18:01:47 PST
Fingers down on the trackpad should stop an animated scroll
Attachments
Patch (9.78 KB, patch)
2021-11-14 18:04 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-11-14 18:04:03 PST
Created attachment 444202 [details] Patch
Wenson Hsieh
Comment 2 2021-11-14 18:44:38 PST
Comment on attachment 444202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444202&action=review > Source/WebCore/platform/mac/ScrollingEffectsController.mm:143 > + return true; Is returning `true` correct for the `PlatformWheelEventPhase::Cancelled` case as well?
Simon Fraser (smfr)
Comment 3 2021-11-14 19:23:39 PST
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 444202 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444202&action=review > > > Source/WebCore/platform/mac/ScrollingEffectsController.mm:143 > > + return true; > > Is returning `true` correct for the `PlatformWheelEventPhase::Cancelled` > case as well? There's no clear logic behind saying that MayBegin and Cancelled are handled so it's fuzzy.
EWS
Comment 4 2021-11-14 20:06:47 PST
Committed r285797 (244241@main): <https://commits.webkit.org/244241@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444202 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-14 20:07:22 PST
<rdar://problem/85397363>
Note You need to log in before you can comment on or make changes to this bug.